From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 0D1A1385AE59 for ; Fri, 15 Jul 2022 20:05:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0D1A1385AE59 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-512-KBq6qDuKMTSPomzABlIRxA-1; Fri, 15 Jul 2022 16:05:37 -0400 X-MC-Unique: KBq6qDuKMTSPomzABlIRxA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2BDF529DD99B; Fri, 15 Jul 2022 20:05:37 +0000 (UTC) Received: from f35-zws-1 (unknown [10.2.17.184]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BE884C04482; Fri, 15 Jul 2022 20:05:36 +0000 (UTC) Date: Fri, 15 Jul 2022 13:05:35 -0700 From: Kevin Buettner To: Tom Tromey Cc: gdb-patches@sourceware.org, Simon Marchi Subject: Re: [PATCH v2] Handle Python 3.11 deprecation of PySys_SetPath and Py_SetProgramName Message-ID: <20220715130535.043c8187@f35-zws-1> In-Reply-To: <87k08enrwd.fsf@tromey.com> References: <20220709155009.176955-1-kevinb@redhat.com> <87k08enrwd.fsf@tromey.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jul 2022 20:05:40 -0000 On Fri, 15 Jul 2022 12:37:54 -0600 Tom Tromey wrote: > >>>>> "Kevin" == Kevin Buettner via Gdb-patches writes: > > Kevin> Python 3.11 deprecates PySys_SetPath and Py_SetProgramName. The > Kevin> PyConfig API replaces these and other functions. This commit uses the > Kevin> PyConfig API to provide equivalent functionality while also preserving > Kevin> support for older versions of Python, i.e. those before Python 3.8. > [...] > > This looks good to me. Thank you for doing this. > > I think this fixes a couple of bugs in bugzilla, so those should be > mentioned in the commit message IMO. I ran into some non-trivial conflicts while rebasing, so I'll send out a v3 patch with the conflicts fixed in addition to mentioning the bugs which were fixed in the commit message. Kevin