From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kevinb@redhat.com>
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by sourceware.org (Postfix) with ESMTPS id 644F43857BBD
 for <gdb-patches@sourceware.org>; Fri, 15 Jul 2022 20:33:28 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 644F43857BBD
Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com
 [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-332-DKISi1S8MTavc4xs-fiUcg-1; Fri, 15 Jul 2022 16:33:19 -0400
X-MC-Unique: DKISi1S8MTavc4xs-fiUcg-1
Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com
 [10.11.54.9])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E3B6C185A7BA;
 Fri, 15 Jul 2022 20:33:18 +0000 (UTC)
Received: from f35-zws-1 (unknown [10.2.17.184])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id 9B956492C3B;
 Fri, 15 Jul 2022 20:33:18 +0000 (UTC)
Date: Fri, 15 Jul 2022 13:33:17 -0700
From: Kevin Buettner <kevinb@redhat.com>
To: Tom Tromey via Gdb-patches <gdb-patches@sourceware.org>
Cc: Tom Tromey <tromey@adacore.com>
Subject: Re: [PATCH] Make 'import gdb.events' work
Message-ID: <20220715133317.1bd0103b@f35-zws-1>
In-Reply-To: <20220607132025.2243948-1-tromey@adacore.com>
References: <20220607132025.2243948-1-tromey@adacore.com>
Organization: Red Hat
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE,
 SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Fri, 15 Jul 2022 20:33:29 -0000

On Tue,  7 Jun 2022 07:20:25 -0600
Tom Tromey via Gdb-patches <gdb-patches@sourceware.org> wrote:

> +  /* Define all internal modules.  These are all imported (and thus
> +     created) during initialization.  */
> +  struct _inittab mods[3] =
> +  {
> +    { "_gdb", init__gdb_module },
> +    { "_gdbevents", gdbpy_events_mod_func },
> +    { nullptr, nullptr }
> +  };

Something I just noticed while looking at a conflict while rebasing
my Python 3.11 deprecation patch:

Is there any reason not to do...

  struct _inittab mods[] =
  ...

instead?

Since I've had to move this hunk of code, I've made the above tweak in
my (soon to come) v3 Python 3.11 deprecation patch.

Kevin