From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 49B773856DDE for ; Wed, 20 Jul 2022 19:45:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 49B773856DDE Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-594-jRuLPSh_PPu4znstW20aMA-1; Wed, 20 Jul 2022 15:45:07 -0400 X-MC-Unique: jRuLPSh_PPu4znstW20aMA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A9A18852AC1 for ; Wed, 20 Jul 2022 19:45:05 +0000 (UTC) Received: from blarsen.com (ovpn-116-8.gru2.redhat.com [10.97.116.8]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0D58D40C1288; Wed, 20 Jul 2022 19:45:04 +0000 (UTC) From: Bruno Larsen To: gdb-patches@sourceware.org Subject: [PATCH v4 09/15] gdb/testsuite: fix gdb.base/msym-bp-shl when running with Clang Date: Wed, 20 Jul 2022 16:44:35 -0300 Message-Id: <20220720194441.168906-11-blarsen@redhat.com> In-Reply-To: <20220720194441.168906-1-blarsen@redhat.com> References: <20220720194441.168906-1-blarsen@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Jul 2022 19:45:17 -0000 Because Clang's -O0 is not as unoptimized as gcc's, one of the functions of gdb.base/msym-bp-shl was being optimized away, making the entire test fail. A lot of the test fail like so: (gdb) break foo Breakpoint 1 at 0x401030 (gdb) FAIL: gdb.base/msym-bp-shl.exp: debug=0: before run: break foo info breakpoint Num Type Disp Enb Address What 1 breakpoint keep y 0x0000000000401030 (gdb) FAIL: gdb.base/msym-bp-shl.exp: debug=0: before run: info breakpoint As the test expects 2 breakpoints to be placed. This can't be easily fixed by adding __attribute__ ((used)) to the function, since Clang will still optimize away the function. Because of this, the test is skipped when the it detects that Clang is being used --- gdb/testsuite/gdb.base/msym-bp-shl.exp | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/gdb/testsuite/gdb.base/msym-bp-shl.exp b/gdb/testsuite/gdb.base/msym-bp-shl.exp index 42adcb191dd..dd7d05bab52 100644 --- a/gdb/testsuite/gdb.base/msym-bp-shl.exp +++ b/gdb/testsuite/gdb.base/msym-bp-shl.exp @@ -22,6 +22,14 @@ if {[skip_shlib_tests]} { return 0 } +# Clang will optimize away the static foo, regardless of using +# __attribute__((used)), so we'll always get a single breakpoint +# making this test useless +if {[test_compiler_info {clang-*-*}]} { + untested "Clang optimizes away one of the functions" + return +} + standard_testfile msym-bp-shl-main.c msym-bp-shl-main-2.c msym-bp-shl-lib.c set srcfile ${srcdir}/${subdir}/${srcfile} set srcfile2 ${srcdir}/${subdir}/${srcfile2} -- 2.31.1