From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 89FAC385840A for ; Sat, 23 Jul 2022 21:42:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 89FAC385840A Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-447-ilfjJQWRM9WRWWJCtiNS6w-1; Sat, 23 Jul 2022 17:42:47 -0400 X-MC-Unique: ilfjJQWRM9WRWWJCtiNS6w-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 357DC3806706; Sat, 23 Jul 2022 21:42:47 +0000 (UTC) Received: from f35-zws-1 (unknown [10.2.16.60]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D44A290A04; Sat, 23 Jul 2022 21:42:46 +0000 (UTC) Date: Sat, 23 Jul 2022 14:42:45 -0700 From: Kevin Buettner To: Jiangshuai Li via Gdb-patches Cc: Jiangshuai Li Subject: Re: [PATCH] gdb/csky support .reg2 for kernel 4.x and later Message-ID: <20220723144245.07768aa7@f35-zws-1> In-Reply-To: <20220722055446.2836-1-jiangshuai_li@linux.alibaba.com> References: <20220722055446.2836-1-jiangshuai_li@linux.alibaba.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Jul 2022 21:42:52 -0000 On Fri, 22 Jul 2022 13:54:46 +0800 Jiangshuai Li via Gdb-patches wrote: > static void > csky_supply_gregset (const struct regset *regset, > - struct regcache *regcache, int regnum, > - const void *regs, size_t len) > + struct regcache *regcache, int regnum, > + const void *regs, size_t len) > { > int i, gregset_num; > const gdb_byte *gregs = (const gdb_byte *) regs ; > @@ -77,8 +79,8 @@ csky_supply_gregset (const struct regset *regset, > for (i = 0; i < gregset_num; i++) > { > if ((regnum == csky_gregset_offset[i] || regnum == -1) > - && csky_gregset_offset[i] != -1) > - regcache->raw_supply (csky_gregset_offset[i], gregs + 4 * i); > + && csky_gregset_offset[i] != -1) > + regcache->raw_supply (csky_gregset_offset[i], gregs + 4 * i); > } > } > So... in the above two hunks of this patch, plus in many other places in the patch, it seems that the only change was to convert tabs to spaces. Could you please resend your patch without these whitespace changes? Not only will it be easier to review, but I think we still prefer the use of tabs in place of leading spaces in GDB's source code. Even if such a change were desirable, we'd prefer to see a separate patch for whitespace changes. Thanks, Kevin