From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id A4B323858C39 for ; Sat, 23 Jul 2022 21:25:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A4B323858C39 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-253-w-McZw_vOzi0QZJ4ZllFkA-1; Sat, 23 Jul 2022 17:25:10 -0400 X-MC-Unique: w-McZw_vOzi0QZJ4ZllFkA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4254A802D1C; Sat, 23 Jul 2022 21:25:10 +0000 (UTC) Received: from f36-1.lan (unknown [10.2.16.60]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7E28DC28118; Sat, 23 Jul 2022 21:25:09 +0000 (UTC) From: Kevin Buettner To: gdb-patches@sourceware.org Cc: Kevin Buettner , Simon Marchi , Eli Zaretskii , Pedro Alves Subject: [PATCH v2] set/show python dont-write-bytecode fixes Date: Sat, 23 Jul 2022 14:23:25 -0700 Message-Id: <20220723212324.1028060-1-kevinb@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Jul 2022 21:25:16 -0000 GDB uses the environment variable PYTHONDONTWRITEBYTECODE to determine whether or not to write the result of byte-compiling python modules when the "python dont-write-bytecode" setting is "auto". Simon noticed that GDB's implementation doesn't follow the Python documentation. At present, GDB only checks for the existence of this environment variable. That is not sufficient though. Regarding PYTHONDONTWRITEBYTECODE, this document... https://docs.python.org/3/using/cmdline.html ...says: If this is set to a non-empty string, Python won't try to write .pyc files on the import of source modules. This commit fixes GDB's handling of PYTHONDONTWRITEBYTECODE by adding an empty string check. This commit also corrects the set/show command documentation for "python dont-write-bytecode". The current doc was just a copy of that for set/show python ignore-environment. During his review of an earlier version of this patch, Eli Zaretskii asked that the help text that I proposed for "set/show python dont-write-bytecode" be expanded. I've done that in addition to clarifying the documentation of this option in the GDB manual. --- gdb/doc/python.texi | 11 ++++++++--- gdb/python/python.c | 32 +++++++++++++++++++++++++------- 2 files changed, 33 insertions(+), 10 deletions(-) diff --git a/gdb/doc/python.texi b/gdb/doc/python.texi index eeb847aeaa8..6d7bb832c22 100644 --- a/gdb/doc/python.texi +++ b/gdb/doc/python.texi @@ -134,9 +134,14 @@ initialized early during @value{GDBN}'s startup process, then this option must be placed into the early initialization file (@pxref{Initialization Files}) to have the desired effect. -By default this option is set to @samp{auto}, in this mode Python will -check the environment variable @env{PYTHONDONTWRITEBYTECODE} to see -if it should write out byte-code or not. +By default this option is set to @samp{auto}. In this mode, provided +the @code{python ignore-environment} setting is @samp{off}, the +environment variable @env{PYTHONDONTWRITEBYTECODE} is examined to see +if it should write out byte-code or not. +@env{PYTHONDONTWRITEBYTECODE} is considered to be off/disabled either +when set to the empty string or when the environment variable doesn't +exist. All other settings, including those which don't seem to make +sense, indicate that it's on/enabled. This option is equivalent to passing @option{-B} to the real @command{python} executable. diff --git a/gdb/python/python.c b/gdb/python/python.c index c7d4157b70c..7997bee2c69 100644 --- a/gdb/python/python.c +++ b/gdb/python/python.c @@ -1866,8 +1866,15 @@ python_write_bytecode () int wbc = 0; if (python_dont_write_bytecode == AUTO_BOOLEAN_AUTO) - wbc = (!python_ignore_environment - && getenv ("PYTHONDONTWRITEBYTECODE") != nullptr) ? 0 : 1; + { + if (python_ignore_environment) + wbc = 1; + else + { + const char *pdwbc = getenv ("PYTHONDONTWRITEBYTECODE"); + wbc = (pdwbc == nullptr || pdwbc[0] == '\0') ? 1 : 0; + } + } else wbc = python_dont_write_bytecode == AUTO_BOOLEAN_TRUE ? 0 : 1; @@ -2346,11 +2353,22 @@ python executable."), add_setshow_auto_boolean_cmd ("dont-write-bytecode", no_class, &python_dont_write_bytecode, _("\ -Set whether the Python interpreter should ignore environment variables."), _(" \ -Show whether the Python interpreter showlist ignore environment variables."), _(" \ -When enabled GDB's Python interpreter will ignore any Python related\n \ -flags in the environment. This is equivalent to passing `-E' to a\n \ -python executable."), +Set whether the Python interpreter should avoid byte-compiling python modules."), _("\ +Show whether the Python interpreter should avoid byte-compiling python modules."), _("\ +When enabled, GDB's embedded Python interpreter won't byte-compile python\n\ +modules. In order to take effect, this setting must be enabled in an early\n\ +initialization file, i.e. those run via the --early-init-eval-command or\n\ +-eix command line options. A 'set python dont-write-bytecode on' command\n\ +can also be issued directly from the GDB command line via the\n\ +--early-init-eval-command or -eiex command line options.\n\ +\n\ +This setting defaults to 'auto'. In this mode, provided the 'python\n\ +ignore-environment' setting is 'off', the environment variable\n\ +PYTHONDONTWRITEBYTECODE is examined to determine whether or not to\n\ +byte-compile python modules. PYTHONDONTWRITEBYTECODE is considered to be\n\ +off/disabled either when set to the empty string or when the\n\ +environment variable doesn't exist. All other settings, including those\n\ +which don't seem to make sense, indicate that it's on/enabled."), set_python_dont_write_bytecode, show_python_dont_write_bytecode, &user_set_python_list, -- 2.36.1