From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80135.outbound.protection.outlook.com [40.107.8.135]) by sourceware.org (Postfix) with ESMTPS id 665DA385840F for ; Mon, 25 Jul 2022 16:22:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 665DA385840F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=xmos.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=xmos.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VMA91goH3WaiQYoSdKxpeF9fEOOQc/U9AilTkh8nsrcDCiNXrUHEUhD1iGpe+qCOG9kaY5Fu+zc2MhJS5D3Hv6SxGV1yQeCwMX3OASQHTXMBOSSzSwdWIMVNWC0TMfbF4cgbRWhx2xxLw8nsly2HfAGvEOOW9hQBKusMmlJk27Fad8i7x4Lt0roYtcDDEreSBzKUOAC39IzUjSDy53KCWieO2ZpFmoAVy4YLL+lfoLYeFj446aEHZWWg7zcyAfgigXakmieCZzbk5qOV34SD+tz8u8tbKaSariN1IcFbM0c0cgtsEWRQ+C6KKVyRWeE0ifqDsKz0ldRRyPJqIcz2FQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0cUuZJOzXu8SZzB6LP2JA0PPiKuxeYQTgtOw718EKEk=; b=U7YswfQavpUq+5kN3fSLh/9bybpikYAcNkkX0CAayXwKKRy4znEQndxDeD1z5dl+03XNSYXuSjLmHE7j3kpcO4CW3luVM4ESiGPm2RjJBUMnhGzqanKgwn5BAuTnAzX6y+rFg+W+kVjRZLOijfojmKl8Ss5G/uv+GMmONSKTPp0gb1EwevLPxI2qJlggCexLTeoLUjPpPTGuNKjA8NAj4oEgw2ye7HnNSLDakD8w1eh6h/xmH0+uow2sXbHm+DaVT1CAA2kF2iKnRlgySnhVeWSD+5jQ6o4DpVrfllNlSOdQ3YTl0f57ru3hMWUZPv8XBd8vgMXgNCEFy7TYhEzL4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=xmos.com; dmarc=pass action=none header.from=xmos.com; dkim=pass header.d=xmos.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xmos1.onmicrosoft.com; s=selector2-xmos1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0cUuZJOzXu8SZzB6LP2JA0PPiKuxeYQTgtOw718EKEk=; b=UJ6zGe/5thwLQh8gPoTxZzAG84XFNPTLrQDQ0DsH4dYq4BcLddQzeD0oYRi50h6uxOUIKbHNCQCAvCWzMP9C2K1xM+yaRHU4/C9YdnbzvOzWrzeltHsXP0hqrMlPtuPZjMGrJlGBD1BQzEIRi3u7K/PvXMOh+5eKcdFPxqH9zrw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=xmos.com; Received: from DB9PR09MB4988.eurprd09.prod.outlook.com (2603:10a6:10:26d::11) by AM0PR09MB4065.eurprd09.prod.outlook.com (2603:10a6:208:1a1::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.14; Mon, 25 Jul 2022 16:22:43 +0000 Received: from DB9PR09MB4988.eurprd09.prod.outlook.com ([fe80::40c8:af21:c73:6490]) by DB9PR09MB4988.eurprd09.prod.outlook.com ([fe80::40c8:af21:c73:6490%7]) with mapi id 15.20.5458.024; Mon, 25 Jul 2022 16:22:43 +0000 From: Ciaran Woodward To: gdb-patches@sourceware.org Subject: [PATCH] gdb: Fix missing first breakpoint in schedule-multiple mode Date: Mon, 25 Jul 2022 17:22:31 +0100 Message-Id: <20220725162231.4473-1-ciaranwoodward@xmos.com> X-Mailer: git-send-email 2.25.1 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: LO4P123CA0645.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:296::16) To DB9PR09MB4988.eurprd09.prod.outlook.com (2603:10a6:10:26d::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a9552c7b-9bda-4482-c1d8-08da6e59e6ba X-MS-TrafficTypeDiagnostic: AM0PR09MB4065:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SxrpTMashsDPAlQll8RVHePRXIc4KI48ThFwyODynOGSDWDGTG6RyjY3SOhFCmetDb/OeadTY9IQFBIMa0OjnRQvp8DAq/HlUCBC1EG6nSdBbG10jmSLDrL+ikecjKq4BF499PQ3Sxd4nTbhvNf2qKoeXN1gQdB76YeejzKtZZoTuiXGwEiBsAPvGpLa44vtir+/UeDcRoXkRxOJ4P3AT1xIzsfrT3xUohvhra2OOnK7CkpiphvwdU6ekWNmUjA0NgqWquHwsWNRQWnxvJsaooGqU/K7v3uK4hNVG5l9yP0QjuSf+TQ+wTxF2wZFtOtH/oTZ78QvRzACSLA7+FspWu8SJMsLNTt65ia4Yo4dQSer6l49B5SrAcUMxZGO+c4U2yRbNyWYmax244zmS0Bxt+HXNSUpWKw5S8i6mrynRsmBKf4eoi0PTqG/bjwL2BT/FLflMqiIAlQhL7azOwB+PS5pu88l6vVH2zAbyDZfL9rxbZjZadTIf2CKyx0mkmCmDjs2kHxXEuLMNAYYqtXIxE0FfELEIucl71+TKbRYoZilr7Z7tc2Wc5M0/LsjXfoXOx0TqLII5eyX/113bwAt4JaCbS0brX9b8BwMk45ddXUnJI304mX541RAVzt94XcqsMlzdApDWFYJkwf/G19BMfVRH3xpmXLq2zXnJq/sOYIy8/9O12GdD5TGrnw3CDpHrDRHwmevYMVYRvgOqRroYwo6gXJyjIgasQsRtabgXy7SStHNWxoInlvKq+gFgj50GklNK12kpgXMpIB1zmOegB1l2cf9bZD1LOyySuEqTl8= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB9PR09MB4988.eurprd09.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(366004)(39840400004)(136003)(396003)(346002)(376002)(5660300002)(36756003)(6916009)(2906002)(8936002)(38100700002)(316002)(8676002)(66946007)(4326008)(38350700002)(2616005)(478600001)(26005)(86362001)(186003)(6486002)(52116002)(107886003)(83380400001)(66476007)(1076003)(6512007)(6666004)(6506007)(41300700001)(66556008); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?uJ7ZZrZF5hANGrIKFuHiq4V88rv8t8m9zBrhpixL6Bi154uGepFkOjesW3X9?= =?us-ascii?Q?tplYTcVxqDaZAyEMN7inNssBVV/2+yWGixdU53Y3QPhTjnNSwE0S20WCObs5?= =?us-ascii?Q?PuzpV5Yu0O5istJy1fGUDoe/BeVwjzbfw+rZnJVN3EnvbGQXb0nGGsVW67jn?= =?us-ascii?Q?puf6d06b1mO+uuaX7nM6DM/j1SmywloAysQqu0VXFwxLx6FWW0vZI3N340Zd?= =?us-ascii?Q?yAhKJtD/IHTQQ7KEZo93FYQptV4j5ict2NQqKjsXmwkgTnmEr7rQ9+DzoKdB?= =?us-ascii?Q?lgqZZOYlqg+qnTJR3GesMGns7JGSFezY/3xILugULgDMsCDXzYJWnte6U2R1?= =?us-ascii?Q?VF/5HUbUGuBxBAZYVGnr7FnCujLjN/PQ2QIY9UnpHeFG54FowY229Dxns934?= =?us-ascii?Q?dxNQhRx95pQdjPW0MDWZECu4DKkcGLNL5CC3xnuZaOC6qtx43XahcMCsZKf1?= =?us-ascii?Q?hL9AGVl4DFW8xuEaiN6ubwOhBnVw9qO/LukIjeIZY2T1T5Ql0AZaGk8bRAKr?= =?us-ascii?Q?e8raWUy4HLhPLKK0c8UL+Yy0pkso/xZJg0ZuC/pJhVVcWdCsYy/Fw8jXeyfk?= =?us-ascii?Q?gHgP2IgSgedtu9pYUb14pmgIzgiCLFZcTZt+QOWbvXIHo9Y8idLqwWHVa/ub?= =?us-ascii?Q?XibozrG+w0Da5cEu7V2WmtZhhLZOPPbseBjdS6xJn+cnhpCoikjrqid+JzHn?= =?us-ascii?Q?BbuYCxNyNzVZ7XF99vlUoMTSa2qQKM19rfXeSc6vCxH/ny5/CfOgqKJP6/1s?= =?us-ascii?Q?XQXsrTy3w3+sFMatnxvCZWA485KUoKKl+Yhbn6lDR6To21/68NslfpKd+Dle?= =?us-ascii?Q?6lrT0LaPS2QIOGlxg4cyrtH7bV5+91Wg0i7pHDkKg7z6Zv47cbx1iYsV0+Cn?= =?us-ascii?Q?mnpILluG7hsMiTwA6CdzZe7etlIrr1yDA2mY+BDRThv2DFKojDAgyPfkfzrw?= =?us-ascii?Q?5GAf2VM3/ivmAupdfWCzoQEBCfcsRKGW60nmAtWvvi5TM2tq1L7rvTepzPAg?= =?us-ascii?Q?mmuLxxdGMQ8AwPkIZvb29YeOvPGllz6s3BOEw3SzMEvCuBPm03QfnJa1U8yb?= =?us-ascii?Q?MqrWwqLY/cOY4xyGtUWuVxe/r+rd0MwIznVFa8XrYG6BfdhKChzUUNj9GCPB?= =?us-ascii?Q?FDln46TTqXoGJ4AbefMg+LRSBBguUiJQnfT1spYRI3r9fvjEz+R1GnaSw4qv?= =?us-ascii?Q?fRPa6LLJ+oDSpTQC0G9E5lRJxkT85yAgI4i6CwpGQuDIBU+Td8qummU/J2KL?= =?us-ascii?Q?zwBjQwVHYw+eQalLACCkrmuNzpvBIwFeYklul6dO3FQ7NVns6IYuWjex+vKk?= =?us-ascii?Q?A/dvZI/ozBTwySi/BCJdeL9rdAzjYMxQnJs11CIGV8PpiMj9n+Guz6DuPsuH?= =?us-ascii?Q?Cd1zN6mp8vidmjY/sYEO8I8oxuqTAWpdhQrCi84Pe7BcspqB89gxrqO0M1Rp?= =?us-ascii?Q?lFj/nCb7iVZORC87iT0nOCYYGqzEWfNxgLQu6VrtwHkDtkB3qQnPTvuItZ/r?= =?us-ascii?Q?1s2emDefNTM0metNDckfAR48+82astQvFoBD8yee3M8g8Mrbevph63+NSlVx?= =?us-ascii?Q?J7dY+XdDN0zkRd+J+NmurEQYrHBAUqv7k7fX5WxFmmV25b0hd7x0fo24Pvq+?= =?us-ascii?Q?Sg=3D=3D?= X-OriginatorOrg: xmos.com X-MS-Exchange-CrossTenant-Network-Message-Id: a9552c7b-9bda-4482-c1d8-08da6e59e6ba X-MS-Exchange-CrossTenant-AuthSource: DB9PR09MB4988.eurprd09.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jul 2022 16:22:42.9427 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 975ecfb1-4080-42d2-a01d-4a4d0707a539 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: h+rOIa1Z8GMkWjrK3BHGZTlEIyf0Og57pFKFad9rDSfYGpU2JC7o+bvj0suvJoVSxQOF9mAQmqGZBXJg3xQZxA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR09MB4065 X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Jul 2022 16:22:47 -0000 Rationale/background: When using schedule-multiple (sched_multi) in gdb, all inferiors are set to continue when the c command is used. However, before this patch, only the 'current' inferior would have its control->stop_soon field cleared. This field causes certain stops to be ignored, and is only intended for initial attach. By not clearing this field before continue, continuing with inferior 2 in focus and with inferior 1 hitting the next breakpoint, would cause gdb to ignore the breakpoint and any attempt to stop the target with Ctrl-C following that - even though the target was already stopped. The only fix was to quit GDB and restart. Solution: With this patch, all inferiors being resumed have their control->stop_soon fields cleared, so gdb does not ignore the breakpoints of any inferior inadvertently. --- gdb/infrun.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/gdb/infrun.c b/gdb/infrun.c index 543cccc5311..894157ed1d1 100644 --- a/gdb/infrun.c +++ b/gdb/infrun.c @@ -2808,18 +2808,18 @@ clear_proceed_status (int step) we're about to resume, implicitly and explicitly. */ for (thread_info *tp : all_non_exited_threads (resume_target, resume_ptid)) clear_proceed_status_thread (tp); + + for(struct inferior* inferior : all_non_exited_inferiors(resume_target)) + inferior->control.stop_soon = NO_STOP_QUIETLY; } - if (inferior_ptid != null_ptid) + if (non_stop && inferior_ptid != null_ptid) { struct inferior *inferior; - if (non_stop) - { - /* If in non-stop mode, only delete the per-thread status of - the current thread. */ - clear_proceed_status_thread (inferior_thread ()); - } + /* If in non-stop mode, only delete the per-thread status of + the current thread. */ + clear_proceed_status_thread (inferior_thread ()); inferior = current_inferior (); inferior->control.stop_soon = NO_STOP_QUIETLY; -- 2.25.1