public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Felix Willgerodt <felix.willgerodt@intel.com>
To: gdb-patches@sourceware.org
Cc: kevinb@redhat.com, aburgess@redhat.com, blarsen@redhat.com,
	Felix Willgerodt <felix.willgerodt@intel.com>
Subject: [PATCH v3 2/2] gdb, testsuite: Adapt gdb.base/callfuncs.exp for new clang warning.
Date: Wed, 27 Jul 2022 10:51:28 +0200	[thread overview]
Message-ID: <20220727085128.2404513-3-felix.willgerodt@intel.com> (raw)
In-Reply-To: <20220727085128.2404513-1-felix.willgerodt@intel.com>

Clang 15.0.0 enabled the warning for deprecated non-prototype functions
by default: https://reviews.llvm.org/D122895
Callfuncs.exp is impacted and won't run due to new warnings:

callfuncs.c:339:5: warning: a function declaration without a prototype is
deprecated in all versions of C and is not supported in C2x
[-Wdeprecated-non-prototype]
int t_float_values (float_arg1, float_arg2)

This patch disables those warnings with -Wno-deprecated-non-prototype.
Removing the test for deprecated syntax would also be an option. But I will
leave that up for others to decide/implement.
---
 gdb/testsuite/gdb.base/callfuncs.exp | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gdb/testsuite/gdb.base/callfuncs.exp b/gdb/testsuite/gdb.base/callfuncs.exp
index 4448cc127ba..fd63f109101 100644
--- a/gdb/testsuite/gdb.base/callfuncs.exp
+++ b/gdb/testsuite/gdb.base/callfuncs.exp
@@ -18,7 +18,9 @@
 
 standard_testfile
 
-set compile_flags {debug}
+# We still want to test non-prototype functions for now, which is why
+# we disable compilers warning about them.
+set compile_flags {debug additional_flags=-Wno-deprecated-non-prototype}
 if [support_complex_tests] {
     lappend compile_flags "additional_flags=-DTEST_COMPLEX"
 }
-- 
2.34.3

Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928


  parent reply	other threads:[~2022-07-27  8:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-27  8:51 [PATCH v3 0/2] Testsuite changes for clang and icc/icx Felix Willgerodt
2022-07-27  8:51 ` [PATCH v3 1/2] gdb, testsuite: Enable testcases that suppress specific warnings, for icc/icx Felix Willgerodt
2022-07-27  8:51 ` Felix Willgerodt [this message]
2022-07-27 17:39 ` [PATCH v3 0/2] Testsuite changes for clang and icc/icx Kevin Buettner
2022-08-10  9:10 ` Willgerodt, Felix
2022-08-18  7:54 ` Willgerodt, Felix
2022-08-18 16:34   ` Kevin Buettner
2022-08-19 13:08     ` Willgerodt, Felix

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220727085128.2404513-3-felix.willgerodt@intel.com \
    --to=felix.willgerodt@intel.com \
    --cc=aburgess@redhat.com \
    --cc=blarsen@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=kevinb@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).