From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lndn.lancelotsix.com (lndn.lancelotsix.com [51.195.220.111]) by sourceware.org (Postfix) with ESMTPS id 65B62385841D for ; Thu, 28 Jul 2022 08:56:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 65B62385841D Received: from octopus (unknown [IPv6:2a01:e34:ef9a:d0b0:57ae:813d:1513:9ef2]) by lndn.lancelotsix.com (Postfix) with ESMTPSA id 91B1188460; Thu, 28 Jul 2022 08:56:31 +0000 (UTC) Date: Thu, 28 Jul 2022 09:56:26 +0100 From: Lancelot SIX To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb: call check_typedef at beginning of dwarf_expr_context::fetch_result Message-ID: <20220728085607.hicavv2k2tg4jfew@octopus> References: <20220728013422.2561677-1-simon.marchi@efficios.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220728013422.2561677-1-simon.marchi@efficios.com> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.11 (lndn.lancelotsix.com [0.0.0.0]); Thu, 28 Jul 2022 08:56:32 +0000 (UTC) X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Jul 2022 08:56:34 -0000 Hi, [...] > diff --git a/gdb/testsuite/gdb.dwarf2/entry-value-typedef.exp b/gdb/testsuite/gdb.dwarf2/entry-value-typedef.exp > new file mode 100644 > index 00000000000..3a3740234fa > --- /dev/null > +++ b/gdb/testsuite/gdb.dwarf2/entry-value-typedef.exp > @@ -0,0 +1,36 @@ > +# Copyright 2022 Free Software Foundation, Inc. > + > +# This program is free software; you can redistribute it and/or modify > +# it under the terms of the GNU General Public License as published by > +# the Free Software Foundation; either version 3 of the License, or > +# (at your option) any later version. > +# > +# This program is distributed in the hope that it will be useful, > +# but WITHOUT ANY WARRANTY; without even the implied warranty of > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > +# GNU General Public License for more details. > +# > +# You should have received a copy of the GNU General Public License > +# along with this program. If not, see . > + > +# The program associated to this test case uncovered a bug in GDB (PR 29374) > +# where a typedef type was used before it was resolved. > + > +standard_testfile .S Shouldn’t there be something like: if { ![istarget x86_64-*-linux* ] } { return } or similar to make sure that we do not try to compile this .S file on incompatible archs? Best, Lancelot. > + > +if {[gdb_compile "$srcdir/$subdir/$srcfile" "$binfile" executable {c++}] != ""} { > + return > +} > + > +clean_restart $binfile > + > +if {![runto_main]} { > + return > +} > + > +gdb_test "catch throw" "Catchpoint $::decimal \\(throw\\)" > +gdb_test "continue" "Catchpoint $::decimal \\(exception thrown\\).*" > + > +# Without the corresponding fix, GDB would hit an internal error before > +# printing the frame for main. > +gdb_test "backtrace" " $::hex in func \\(t=t@entry=@$::hex: 1234\\).* $::hex in main .*" > -- > 2.37.1 >