From: Jiangshuai Li <jiangshuai_li@linux.alibaba.com>
To: gdb-patches@sourceware.org
Cc: Jiangshuai Li <jiangshuai_li@linux.alibaba.com>
Subject: [committed] gdb/csky fix build error in ubuntu20_04
Date: Tue, 9 Aug 2022 10:22:02 +0800 [thread overview]
Message-ID: <20220809022202.3667-1-jiangshuai_li@linux.alibaba.com> (raw)
build error in: https://builder.sourceware.org/buildbot/#/builders/170/builds/246
...
../../binutils-gdb/gdb/csky-linux-tdep.c: In function ‘void
csky_supply_fregset(const regset*, regcache*, int, const void*, size_t)’:
../../binutils-gdb/gdb/csky-linux-tdep.c:194:18: error: format ‘%ld’
expects argument of type ‘long int’, but argument 2 has type ‘size_t’
{aka ‘unsigned int’} [-Werror=format=]
194 | warning (_("Unknow size %ld of section .reg2, can not get
value"
|
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
195 | " of float registers."), len);
...
Fix it via using %s vs pulongest suggested by Tom.
---
gdb/csky-linux-tdep.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/gdb/csky-linux-tdep.c b/gdb/csky-linux-tdep.c
index 106f629b8b0..ae5d2bba33c 100644
--- a/gdb/csky-linux-tdep.c
+++ b/gdb/csky-linux-tdep.c
@@ -191,8 +191,8 @@ csky_supply_fregset (const struct regset *regset,
}
else
{
- warning (_("Unknow size %ld of section .reg2, can not get value"
- " of float registers."), len);
+ warning (_("Unknow size %s of section .reg2, can not get value"
+ " of float registers."), pulongest (len));
}
}
@@ -272,8 +272,8 @@ csky_collect_fregset (const struct regset *regset,
}
else
{
- warning (_("Unknow size %ld of section .reg2, will not set value"
- " of float registers."), len);
+ warning (_("Unknow size %s of section .reg2, will not set value"
+ " of float registers."), pulongest (len));
}
}
--
2.25.1
reply other threads:[~2022-08-09 2:22 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220809022202.3667-1-jiangshuai_li@linux.alibaba.com \
--to=jiangshuai_li@linux.alibaba.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).