From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd2e.google.com (mail-io1-xd2e.google.com [IPv6:2607:f8b0:4864:20::d2e]) by sourceware.org (Postfix) with ESMTPS id 22D253858C56 for ; Sat, 13 Aug 2022 00:54:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 22D253858C56 Received: by mail-io1-xd2e.google.com with SMTP id x64so2089455iof.1 for ; Fri, 12 Aug 2022 17:54:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=uOb/aVNKlhhtlk7vzjuew5JVDwc24RBVqtYXXm4AgIE=; b=nLpWWtXCsoMBf5t70daZgyqC6ccD7kycXNFGZqJAXKL+z9ipQxFDtqqCi2ySH/MQiC 19iTspOy2P0WJkumeXjuZDX7uHVzsQYv/6fpiValNB1WOdngAU/ue4TUl2Y0KjR0/zv8 r4umFcWm8rvlSBTYGKlhpyaFSfMS0vqZbpMwvaYFcD+Hq0L4thjc8liA0PpqtmRTwp34 PoupJWIiiEfJ7ODpHR/9UXr35OcmRxXe5oasiPFo6nGh/EempRY3cf4pRo9XizIUdLYs 6AC4lpQ7so2kmoYBzHv/kLybklNfrVVADi2hvUY9/etuJVPSFM0AD+2/1uJk5CFRcg6h LMlQ== X-Gm-Message-State: ACgBeo1fqLZJDfYJqMr/YrynOtCc7+FmRmhON8O09IuV7wrLzXOSd7Uq rNGCxNGxjbJEw2Nhiy7IuhXUTauEnZQYjg== X-Google-Smtp-Source: AA6agR54DBrAg2ATTFo2uFJlsgN6CXRBVAAY1y3FqbN6xUIvWe9pzCrMigkoWejFBa4vwvN4YBBKPA== X-Received: by 2002:a05:6602:2c52:b0:67c:19d6:b628 with SMTP id x18-20020a0566022c5200b0067c19d6b628mr2627060iov.151.1660352086448; Fri, 12 Aug 2022 17:54:46 -0700 (PDT) Received: from murgatroyd.Home (71-211-185-228.hlrn.qwest.net. [71.211.185.228]) by smtp.gmail.com with ESMTPSA id p17-20020a056638217100b00343455007f7sm494366jak.110.2022.08.12.17.54.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Aug 2022 17:54:45 -0700 (PDT) From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH 02/14] Free ui::line_buffer Date: Fri, 12 Aug 2022 18:54:30 -0600 Message-Id: <20220813005442.4163512-3-tromey@adacore.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220813005442.4163512-1-tromey@adacore.com> References: <20220813005442.4163512-1-tromey@adacore.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Aug 2022 00:54:49 -0000 A ui initializes its line_buffer, but never calls buffer_free on it. This patch fixes the oversight. I found this by inspection. --- gdb/top.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gdb/top.c b/gdb/top.c index 453fa236db1..10983919011 100644 --- a/gdb/top.c +++ b/gdb/top.c @@ -352,6 +352,8 @@ ui::~ui () delete m_gdb_stdin; delete m_gdb_stdout; delete m_gdb_stderr; + + buffer_free (&line_buffer); } /* Open file named NAME for read/write, making sure not to make it the -- 2.34.1