From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd30.google.com (mail-io1-xd30.google.com [IPv6:2607:f8b0:4864:20::d30]) by sourceware.org (Postfix) with ESMTPS id 6CE863858C54 for ; Sat, 13 Aug 2022 00:54:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6CE863858C54 Received: by mail-io1-xd30.google.com with SMTP id x64so2089510iof.1 for ; Fri, 12 Aug 2022 17:54:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=olJ1jYSR0frK8LT59qc8EJxx1btyE2vdQdtdliHjp8U=; b=5Ga9iudF+vqrNiTG6zsAWP5+WFJNIU/7J5kMqRmzQ+61bYo5qzB0nPi5pCzllRC6Hx s9INSrUWEAaYeVj1nF6K+5IdUG4KroOlm36ToVhpN1ZYivK8ooWKNwZDoRLg7VJimqzQ Raag05CE++9nVN1DAYvp6mNEmXJ6biX6RNzTV/eOBZR8qbZzAZ/BBlvNzllbTjeY23KA hPGlPoO9ZyRDQc03Wmn3tcCrVTCJ8l80SJtl0Lgio8lZ3aosICKDj8yyMcpkB21pwRYl lb/HP/22SmhblUIMFTEAIIjtUDidx83+eIJF/myM6mGlhIRH7ovzH55mgp20vD35WSns Aa+A== X-Gm-Message-State: ACgBeo03wSnqK2OSu8jV83fSZhyH62zbiatWfuevTap+DsbvOzQaF2RP jNnxilBcQAKq14Zn2l4nMtVtAHA7C2IrSw== X-Google-Smtp-Source: AA6agR4EGZ+FkFWH+eIKExDL2uKp/ORZJDmZfbJuQyeU3VtBX6jfOm9qNIo+e/3xAs+ha65CXHrdlA== X-Received: by 2002:a05:6602:1602:b0:67c:d660:397 with SMTP id x2-20020a056602160200b0067cd6600397mr2699202iow.163.1660352087695; Fri, 12 Aug 2022 17:54:47 -0700 (PDT) Received: from murgatroyd.Home (71-211-185-228.hlrn.qwest.net. [71.211.185.228]) by smtp.gmail.com with ESMTPSA id p17-20020a056638217100b00343455007f7sm494366jak.110.2022.08.12.17.54.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Aug 2022 17:54:47 -0700 (PDT) From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH 04/14] Remove the "for moment" comments Date: Fri, 12 Aug 2022 18:54:32 -0600 Message-Id: <20220813005442.4163512-5-tromey@adacore.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220813005442.4163512-1-tromey@adacore.com> References: <20220813005442.4163512-1-tromey@adacore.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Aug 2022 00:54:49 -0000 A few spots setting some gdb output stream variables have a "for moment" comment. These comments aren't useful and I think the moment has passed -- these are permanent now. --- gdb/event-top.c | 4 ++-- gdb/main.c | 4 ++-- gdb/tui/tui-io.c | 8 ++++---- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/gdb/event-top.c b/gdb/event-top.c index 6f67659a36b..3d7bf4ad560 100644 --- a/gdb/event-top.c +++ b/gdb/event-top.c @@ -1336,8 +1336,8 @@ gdb_setup_readline (int editing) gdb_stdout = new pager_file (new stdio_file (ui->outstream)); gdb_stderr = new stderr_file (ui->errstream); gdb_stdlog = new timestamped_file (gdb_stderr); - gdb_stdtarg = gdb_stderr; /* for moment */ - gdb_stdtargerr = gdb_stderr; /* for moment */ + gdb_stdtarg = gdb_stderr; + gdb_stdtargerr = gdb_stderr; /* If the input stream is connected to a terminal, turn on editing. However, that is only allowed on the main UI, as we can only have diff --git a/gdb/main.c b/gdb/main.c index 8c97987956b..91fa1966738 100644 --- a/gdb/main.c +++ b/gdb/main.c @@ -676,8 +676,8 @@ captured_main_1 (struct captured_main_args *context) main_ui = new ui (stdin, stdout, stderr); current_ui = main_ui; - gdb_stdtargerr = gdb_stderr; /* for moment */ - gdb_stdtargin = gdb_stdin; /* for moment */ + gdb_stdtargerr = gdb_stderr; + gdb_stdtargin = gdb_stdin; if (bfd_init () != BFD_INIT_MAGIC) error (_("fatal error: libbfd ABI mismatch")); diff --git a/gdb/tui/tui-io.c b/gdb/tui/tui-io.c index deea9b90afc..51f08168a90 100644 --- a/gdb/tui/tui-io.c +++ b/gdb/tui/tui-io.c @@ -839,8 +839,8 @@ tui_setup_io (int mode) gdb_stdout = tui_stdout; gdb_stderr = tui_stderr; gdb_stdlog = tui_stdlog; - gdb_stdtarg = gdb_stderr; /* for moment */ - gdb_stdtargerr = gdb_stderr; /* for moment */ + gdb_stdtarg = gdb_stderr; + gdb_stdtargerr = gdb_stderr; current_uiout = tui_out; /* Save tty for SIGCONT. */ @@ -852,8 +852,8 @@ tui_setup_io (int mode) gdb_stdout = tui_old_stdout; gdb_stderr = tui_old_stderr; gdb_stdlog = tui_old_stdlog; - gdb_stdtarg = gdb_stderr; /* for moment */ - gdb_stdtargerr = gdb_stderr; /* for moment */ + gdb_stdtarg = gdb_stderr; + gdb_stdtargerr = gdb_stderr; current_uiout = tui_old_uiout; /* Restore readline. */ -- 2.34.1