From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 20C003858CDA for ; Tue, 16 Aug 2022 15:05:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 20C003858CDA Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 27GF5e0Z026019 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 16 Aug 2022 11:05:45 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 27GF5e0Z026019 Received: from simark.localdomain (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 3D2051E222; Tue, 16 Aug 2022 11:05:40 -0400 (EDT) From: Simon Marchi To: gdb-patches@sourceware.org Subject: [pushed] gdb/testsuite: fix breakpoint script output in gdb.mi/mi-break.exp Date: Tue, 16 Aug 2022 11:05:39 -0400 Message-Id: <20220816150539.750248-1-simon.marchi@polymtl.ca> X-Mailer: git-send-email 2.37.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Tue, 16 Aug 2022 15:05:40 +0000 X-Spam-Status: No, score=-3190.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Aug 2022 15:05:47 -0000 Commit 9db0d8536dbc ("gdb/mi: fix breakpoint script field output") fixed the output of the script key in the MI breakpoint output, from script={"print 10","continue"} to script=["print 10","continue"] However, it missed updating this test case, which still tests for the old (broken) form, causing: FAIL: gdb.mi/mi-break.exp: mi-mode=main: test_breakpoint_commands: breakpoint commands: check that commands are set (unexpected output) FAIL: gdb.mi/mi-break.exp: mi-mode=separate: test_breakpoint_commands: breakpoint commands: check that commands are set (unexpected output) Update the test to expect the new form. Change-Id: I174919d4eea53e96d914ca9bd1cf6f01c8de30b8 --- gdb/testsuite/gdb.mi/mi-break.exp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/testsuite/gdb.mi/mi-break.exp b/gdb/testsuite/gdb.mi/mi-break.exp index b64fe1969404..24353379ffe7 100644 --- a/gdb/testsuite/gdb.mi/mi-break.exp +++ b/gdb/testsuite/gdb.mi/mi-break.exp @@ -203,7 +203,7 @@ proc_with_prefix test_breakpoint_commands {} { # seen. set bp_script [mi_make_breakpoint -number 7 -disp keep -func callee2 \ -file ".*basics.c" -line $line_callee2_body \ - -script {\{"print 10","continue"\}}] + -script {\["print 10","continue"\]}] mi_gdb_test "-break-info 7" \ "\\^done,[mi_make_breakpoint_table [list $bp_script]]" \ "breakpoint commands: check that commands are set" base-commit: 02d04eac24f497e34ac9869bac5bfb1e044a6b62 -- 2.37.1