From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2070.outbound.protection.outlook.com [40.107.20.70]) by sourceware.org (Postfix) with ESMTPS id DD0553858D37 for ; Wed, 17 Aug 2022 08:34:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DD0553858D37 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=hqN3a7+e3KEQ+PF+70FX4h8hwXdO3ANMn4G2Nw0tjo+t1/7ZIJ31rJnin3IW9Cg+c91Ew1lklsopR17pJzjf2hxpOO4mpKMn1b8v/s56t0FoaxQhnG+VUwbcJhgr4FgMhKEI+sNQ6q5LJQuF+ZSt6V2lr+lYtlxsm9/gYnUKFkLdaq+QwN+hgyvxR7yn8bcDtl4ARZe3gzkbfxoBPaRLQn78HNxlzosQM5sZjuRhOaDTvRS7MGgSq0Y2sda/YD5QXPCvdU8ETb7yfjYx0lOZvQqgutdtZn+SYhdD4hmhhxotuqber5kBU0fwuHDaKqFL8N/WFwdnAEAPbDKSg8VT4g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=I3XAlY7oMlnQelEnXayMvkgQEjv5qti9bWaL/S9s2xk=; b=b5llyFqilWwV8DAYlE+vi9brrWexUITaPNnl4sLCMUut4yB5EcsCIHAjmhUE/St/SGHA7bOOqWCvRVRxowjtNzKhKxxiDvliTHCQNed78xBNlCTUZ/oJua8kbbXhy2jGLNNr0mey81puaGb5Ux+NglLaJ0cPUZXSN2WeX4+h9PuZe1P4lPMClSCNiIsL1vsJzFLNzsgoy2NQT7lR9zT71cLlagv3vrcrtONEsFb8kkeqVut0r8KgpCH2n7i3kRuhd69/tSKgZxWz+zxFi7eZWdXht3ntpFydN2dHHbAp6lkwuDavcbcVM9rmHL4JF2sDOUKHQp1s/iWQ93vI+Ug6XA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1, 1, smtp.mailfrom=arm.com] dmarc=[1, 1, header.from=arm.com]) Received: from AS8PR04CA0092.eurprd04.prod.outlook.com (2603:10a6:20b:31e::7) by AM9PR08MB6772.eurprd08.prod.outlook.com (2603:10a6:20b:305::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5525.10; Wed, 17 Aug 2022 08:34:12 +0000 Received: from AM7EUR03FT018.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:31e:cafe::fc) by AS8PR04CA0092.outlook.office365.com (2603:10a6:20b:31e::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5525.19 via Frontend Transport; Wed, 17 Aug 2022 08:34:12 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT018.mail.protection.outlook.com (100.127.140.97) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5546.15 via Frontend Transport; Wed, 17 Aug 2022 08:34:12 +0000 Received: ("Tessian outbound c883b5ba7b70:v123"); Wed, 17 Aug 2022 08:34:12 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: cadf53c3800904be X-CR-MTA-TID: 64aa7808 Received: from ea5cf883eb79.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 9BD0F583-7247-4C8F-887D-182BC657A8A4.1; Wed, 17 Aug 2022 08:34:04 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ea5cf883eb79.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 17 Aug 2022 08:34:04 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bzXBEUoxTUKMum4CtLtprevd0ySL3w6Xyg2Ib0spO/BXrey5jxzc9JPbVhyj+jgKUVT7XbgrzE1f/MmlwiHNe7YmYIbnbqKZq5YqBQ5oMoVC9NzpY3jqGqge+m0FmFiDDBnurGtyAFKq+MJM3y+Saer8K0mFt+6p++ja8bsnk48hS+vpubWc3QjqVk6PW4Ns4gllLgIeSnvslxXEtW94w95OFnx3ojwBIFuBaSrfbBk53/1olncY448CuzHIMticmZ20WF0ATRbiANCaEeT8wsrsA5Xx6CIdcGzOUbymJhnDzWeLfKIPBnW0CThlmEMRt0J/Yet7NUYjcHX3D3b1mA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=I3XAlY7oMlnQelEnXayMvkgQEjv5qti9bWaL/S9s2xk=; b=eEiekZkJ0FDkIYK8L3Xl6lKhhLfQGbfHfiw7cG4hrjfI9DRPiIbLpkEVL1lYA1iJJtjF5a1JdUgDMoNA3RTgiEe7JYrdgOHvf4NSA+8O6mFBSQ0kfh64/8B2WaC7SR0dyDKhyPxNYsMNOGZV5hkD3lXwE3659JXFKkOSWPhNPV68o7+g9qrXcXd43V5WdrBTKSO+YI2YGYU8hjXkARlxHWL0cSzfqy05kSjSbLGPAaMa6JwFyipsg+qyjlNS1Dsg1QwqJfkIPdMP8f1LeGM64Ao5C2oI2mZCwS1PHrWuzKmDxGL0IR0OZuz+fckIhMFYIaj7XJKvRmp5v6WbTYCTGQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none Received: from DB8PR03CA0030.eurprd03.prod.outlook.com (2603:10a6:10:be::43) by PAVPR08MB8989.eurprd08.prod.outlook.com (2603:10a6:102:320::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.16; Wed, 17 Aug 2022 08:34:02 +0000 Received: from DBAEUR03FT040.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:be:cafe::5f) by DB8PR03CA0030.outlook.office365.com (2603:10a6:10:be::43) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5525.19 via Frontend Transport; Wed, 17 Aug 2022 08:34:02 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C Received: from nebula.arm.com (40.67.248.234) by DBAEUR03FT040.mail.protection.outlook.com (100.127.142.157) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5546.15 via Frontend Transport; Wed, 17 Aug 2022 08:34:02 +0000 Received: from AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2507.9; Wed, 17 Aug 2022 08:33:40 +0000 Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.9; Wed, 17 Aug 2022 08:33:40 +0000 Received: from e129171.arm.com (10.57.12.217) by mail.arm.com (10.251.24.31) with Microsoft SMTP Server id 15.1.2507.9 via Frontend Transport; Wed, 17 Aug 2022 08:33:40 +0000 From: Luis Machado To: Subject: [PATCH] [aarch64] Remove handling of ADR/ADRP from prologue analyzer Date: Wed, 17 Aug 2022 09:33:34 +0100 Message-ID: <20220817083334.139191-1-luis.machado@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-Correlation-Id: a101b059-b14f-40a8-60ee-08da802b430d X-MS-TrafficTypeDiagnostic: PAVPR08MB8989:EE_|AM7EUR03FT018:EE_|AM9PR08MB6772:EE_ x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Ai27n+luJB1yHxXznM0Hm2mqQJSEmJv2bu8MSR2RaJ/sJPxoNK37nRm+JKOSdUM4La/b7sQKq3bIlXgDmGuKcUqc9vdYAm+f8hK+wqOjJcs5oURxqzO4ag179MABBQbc6OmeObFoCR9yhFGrU3O3vwyS0LUY7at/TNPrM5TjAPEIgTUKhAs+2x1OXmnCipP5jGlTM+pEk5P8IPwSAfwDzLW5AqfHT4MG3YsyCGGyNDnr1Sxk5NFUlqtC7hN7TWE5iXyVlr29Fc+g0cAkg03sxMrt1mCLyse8q29D2ZIen9QIVo267hi3mLtKEmkXDw5Nn59Gp5gWIxMA6tDrNmvjmKFTsd93E6QAgJbjvasInfc2qI5mPMixrsKdnaPMqYPjaSMN70dg/nfda7fd/bppDhLjwP7Jo+GTOCU2sKh0xrMxTaZPFYBa5jFDLGowIkEC7T/0+a59Kci13olJvxdeZkPOFtoJ1T9zXzFi1hwtF1uw6ip/nxlt/NuCrLUGrCLrmg29J8ELYybENZe0VFm7ESfBERSoYl8/UTPJLXcFkIXYRC5mnx1q3ISibLLhX0Sk4/j6IXYBcWiGcj2pCqQV/b8G0mNizJFDLIvAwtoX1QEv11eo+SJaXTcKoYx2pwaPMIJ4y3ZiQdCM6bao8+jBet9WzLmLIfiUfNFJyD1wzbbg65IONrDaSHqYHj0LLB5VK125BRjx4i8Uwgm5wcwJXsFrIDxGS0hAPEkHq38vbQbQGLb+ZTY83IrnRVWiTgjo8Sod2VKbuucDuKcEiUsmnwTNN+PjufhWkVcz/TXOA0SYuAUH7wqqytup/226wC5lW2IFa08RcdSX7LpMp7Ig4j+6wuzDcWibjocaaW9J4VEA7XuIF5fX6R/cCbucfg7cGpvn/fTzskyv8ya3FBQtPA== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:nebula.arm.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230016)(4636009)(136003)(396003)(376002)(39860400002)(346002)(36840700001)(46966006)(40470700004)(8936002)(41300700001)(478600001)(82310400005)(83380400001)(966005)(6666004)(7696005)(2616005)(26005)(47076005)(44832011)(1076003)(186003)(2906002)(40460700003)(6916009)(426003)(40480700001)(5660300002)(336012)(316002)(70206006)(8676002)(82740400003)(70586007)(86362001)(356005)(81166007)(36756003)(36860700001)(36900700001); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB8989 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT018.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 3bb04811-2f06-48fa-4584-08da802b3d1c X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IrCq5QcfQJbBjXn5PP8st+IQekVyybXMMgNtc1gT2RiJw+p7bbB8uU+PVFAwWhc/mCElj/A3R1Y4CJENexbZC4hqCq52I9ZfxgjF70wm8fzoq5lHCSt8oK5+/JvR1h91fS2AUVbJdtjuN9pkiN8KbTXnEA30Ju5hw9aw0Dk6bx5VAw1ATYrYwz3Q0cPfI6ov4Ibed+Ff/qTLl67vLIytBd7ik1Bfr0hygrsOYkuAwQcr/cdTCFmSHQnZLsrkEh4lz1fKkaXXgx95hMWJCxM5qyeQy3m8nOgAR6jMyr7+v1uIcG5a020x4sTjCrdZBj7QNdlzusef1bP1h0RL7cwrH7Hk1zTXcx576YFSc8psEo5aWDKHaftCiQy/+uCLd3PmNEbPndnZRMKTNtgr5Pqput76r3vD1LfwgnORpYRrRcQPRndrzzf9xil5VfJKcwKE9igICxtnag6G9FtctW7rLjs3/yqC5AJP/5lHc5yKHgX8Bhaxd6Lc7aP28Zv1b37j0zumPxxePUHfY84MQmCD6vJyI8xVvkg5fnbt9vhI/PUHDpdap+4S4Uq5oeISVbCsBZ8xjqMK6Vp0N41yTpREE6ijjgh4duTPjPO9OP2iRyFYAipDn/3byN5+TxPjsurML0C3NhnYIhGd6t73Zt+cMvNBPdI3svdCyH9zh1iz/j8uZRiO4QHzLj/qpFMmmdbjRFDNJVhn+HLdsKYRV0T0O0DUnx2tAIzUh/q69EEY/PaUE+1AfT6XKZmaSPBSMBqb7Z/k94NUxOgR05IDux6iNizPxKdlxpYIgbYt44aQSa6n+eyRQmPBghxapWxJDiQAQC8MmD1PeyH42/uJ9e/7Dm07P9jwZ7f6FyMJZAG7sm8= X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230016)(4636009)(39860400002)(346002)(396003)(376002)(136003)(46966006)(40470700004)(36840700001)(36860700001)(2616005)(2906002)(5660300002)(83380400001)(6916009)(8676002)(44832011)(36756003)(70206006)(8936002)(316002)(70586007)(966005)(6666004)(81166007)(478600001)(7696005)(40460700003)(41300700001)(40480700001)(26005)(1076003)(82310400005)(186003)(336012)(47076005)(426003)(86362001)(82740400003); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Aug 2022 08:34:12.2620 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a101b059-b14f-40a8-60ee-08da802b430d X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT018.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6772 X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FORGED_SPF_HELO, GIT_PATCH_0, KAM_DMARC_NONE, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Aug 2022 08:34:18 -0000 As reported by Tom in https://sourceware.org/pipermail/gdb-patches/2022-August/191357.html, the aarch64 prologue analyzer considers the adrp instruction in the gdb.dwarf2/dw2-dir-file-name.exp testcase to be part of a prologue. The function has no prologue though, and it only loads the volatile variable from memory. GDB should not skip any instructions in this case. Doing some archaeology, it seems handling for adr/adrp in prologues was included with the original aarch64 port. It might've been an oversight. In the particular case of gdb.dwarf2/dw2-dir-file-name.exp, the analyzer skips a couple instructions and leaves us in a nice spot where the address to the variable "v" is already in w0. But no prologues exists. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=29481 --- gdb/aarch64-tdep.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c index f747ebda1ab..0385bc18632 100644 --- a/gdb/aarch64-tdep.c +++ b/gdb/aarch64-tdep.c @@ -354,14 +354,6 @@ aarch64_analyze_prologue (struct gdbarch *gdbarch, regs[rd] = pv_subtract (regs[rn], regs[rm]); } - else if (inst.opcode->iclass == pcreladdr - && inst.operands[1].type == AARCH64_OPND_ADDR_ADRP) - { - gdb_assert (aarch64_num_of_operands (inst.opcode) == 2); - gdb_assert (inst.operands[0].type == AARCH64_OPND_Rd); - - regs[inst.operands[0].reg.regno] = pv_unknown (); - } else if (inst.opcode->iclass == branch_imm) { /* Stop analysis on branch. */ -- 2.25.1