public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Nils-Christian Kempke <nils-christian.kempke@intel.com>
To: gdb-patches@sourceware.org
Cc: tom@tromey.com, Nils-Christian Kempke <nils-christian.kempke@intel.com>
Subject: [PATCH v2 4/4] testsuite, fortran: make kfail gfortran specific
Date: Wed, 31 Aug 2022 11:36:50 +0200	[thread overview]
Message-ID: <20220831093650.674582-5-nils-christian.kempke@intel.com> (raw)
In-Reply-To: <20220831093650.674582-1-nils-christian.kempke@intel.com>

The modified test in function-calls.exp actually passes with ifort and
ifx.  The particular fail seems to be specific to gfortran.  When the
test was introduced it was only tested with gfortran (actually the
whole patch was written with gfortran and the GNU Fortran argument
passing convention in mind).
---
 gdb/testsuite/gdb.fortran/function-calls.exp | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gdb/testsuite/gdb.fortran/function-calls.exp b/gdb/testsuite/gdb.fortran/function-calls.exp
index bc0192be064..533283b9ef8 100644
--- a/gdb/testsuite/gdb.fortran/function-calls.exp
+++ b/gdb/testsuite/gdb.fortran/function-calls.exp
@@ -102,7 +102,9 @@ gdb_test "p sum_some(1,2)" " = 3"
 
 # Paragraph 10: optional value arguments. There is insufficient DWARF
 # information to reliably make this case work.
-setup_kfail "gdb/24305" *-*-*
+if { [test_compiler_info {gfortran-*} f90] } {
+    setup_kfail "gdb/24305" *-*-*
+}
 gdb_test "p one_arg_value(10)" " = 10"
 
 # DW_AT_artificial formal parameters must be passed manually. This
-- 
2.25.1

Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928


  parent reply	other threads:[~2022-08-31  9:37 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-31  9:36 [PATCH v2 0/4] Adapt Fortran testsuite for ifort Nils-Christian Kempke
2022-08-31  9:36 ` [PATCH v2 1/4] testsuite, fortran: make mixed-lang-stack less compiler dependent Nils-Christian Kempke
2022-08-31  9:36 ` [PATCH v2 2/4] testsuite, fortran: Remove self assignment non-statements Nils-Christian Kempke
2022-08-31  9:36 ` [PATCH v2 3/4] testsuite, fortran: adapt tests for ifort's 'start' behavior Nils-Christian Kempke
2022-08-31  9:36 ` Nils-Christian Kempke [this message]
2022-09-19 10:18 ` [PING][PATCH v2 0/4] Adapt Fortran testsuite for ifort Kempke, Nils-Christian
2022-09-19 10:18   ` Kempke, Nils-Christian
2022-09-26 14:02   ` [PING 2][PATCH " Kempke, Nils-Christian
2022-09-26 14:02     ` Kempke, Nils-Christian
2022-10-05 20:23     ` [PING 3][PATCH " Kempke, Nils-Christian
2022-10-05 20:23       ` Kempke, Nils-Christian
2022-10-13  8:52       ` [PING 4][PATCH " Kempke, Nils-Christian
2022-10-13  8:52         ` Kempke, Nils-Christian
2022-10-21  8:15         ` [PING 5][PATCH " Kempke, Nils-Christian
2022-10-21  8:15           ` Kempke, Nils-Christian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220831093650.674582-5-nils-christian.kempke@intel.com \
    --to=nils-christian.kempke@intel.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).