From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lug-owl.de (lug-owl.de [188.68.32.151]) by sourceware.org (Postfix) with ESMTPS id A93633858281 for ; Sat, 3 Sep 2022 06:57:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A93633858281 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=lug-owl.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=lug-owl.de Received: by lug-owl.de (Postfix, from userid 1001) id 6CF9342029; Sat, 3 Sep 2022 08:57:32 +0200 (CEST) Date: Sat, 3 Sep 2022 08:57:32 +0200 From: Jan-Benedict Glaw To: Andrew Burgess Cc: gdb-patches@sourceware.org Subject: Re: [PUSHED] sim: fixes for libopcodes styled disassembler Message-ID: <20220903065732.eb4sqco3zuk53ztu@lug-owl.de> References: <20220404214632.1103903-1-aburgess@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ylxaiclprgzfahrw" Content-Disposition: inline In-Reply-To: <20220404214632.1103903-1-aburgess@redhat.com> X-Operating-System: Linux chamaeleon 5.14.0-0.bpo.2-amd64 X-gpg-fingerprint: 250D 3BCF 7127 0D8C A444 A961 1DBD 5E75 8399 E1BB X-gpg-key: wwwkeys.de.pgp.net X-Echelon-Enable: howto poison arsenous mail psychological biological nuclear warfare test the bombastical terror of flooding the spy listeners explosion sex drugs and rock'n'roll X-TKUeV: howto poison arsenous mail psychological biological nuclear warfare test the bombastical terror of flooding the spy listeners explosion sex drugs and rock'n'roll X-message-flag: Please send plain text messages only. Do not send HTML emails. Thank you. User-Agent: NeoMutt/20170113 (1.7.2) X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Sep 2022 06:57:51 -0000 --ylxaiclprgzfahrw Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, 2022-04-04 22:46:32 +0100, Andrew Burgess via Gdb-patches wrote: > I've gone ahead and pushed the patch below without review, despite it > being non-trivial. I stupidly managed to break several sim targets, > and I wanted to undo the breakage asap. >=20 > Despite being quite large, I hope nothing in here is too > controversial. However, if there is any feedback, do please leave it > and I'll be happy to fix any issues in a follow up patch. >=20 > Sorry for the breakage, and thank you for your understanding. =2E../configure --prefix=3D... --target=3Dsparc-linux make V=3D1 all-gdb [...] rm -f gdb g++ -g -O2 -pthread \ -o gdb gdb.o ada-exp.o ada-lang.o ada-tasks.o ada-typeprint.o ada-v= alprint.o ada-varobj.o addrmap.o agent.o alloc.o annotate.o arch-utils.o as= ync-event.o auto-load.o auxv.o ax-gdb.o ax-general.o bcache.o bfd-target.o = block.o blockframe.o break-catch-exec.o break-catch-fork.o break-catch-load= =2Eo break-catch-sig.o break-catch-syscall.o break-catch-throw.o breakpoint= =2Eo bt-utils.o btrace.o build-id.o buildsym-legacy.o buildsym.o c-exp.o c-= lang.o c-typeprint.o c-valprint.o c-varobj.o charset.o cli-out.o cli/cli-cm= ds.o cli/cli-decode.o cli/cli-dump.o cli/cli-interp.o cli/cli-logging.o cli= /cli-option.o cli/cli-script.o cli/cli-setshow.o cli/cli-style.o cli/cli-ut= ils.o coff-pe-read.o coffread.o compile/compile-c-support.o compile/compile= -c-symbols.o compile/compile-c-types.o compile/compile-cplus-symbols.o comp= ile/compile-cplus-types.o compile/compile-loc2c.o compile/compile-object-lo= ad.o compile/compile-object-run.o compile/compile.o complaints.o completer.= o copying.o corefile.o corelow.o cp-abi.o cp-name-parser.o cp-namespace.o c= p-support.o cp-valprint.o ctfread.o d-exp.o d-lang.o d-namespace.o d-valpri= nt.o dbxread.o dcache.o debug.o debuginfod-support.o dictionary.o disasm-se= lftests.o disasm.o displaced-stepping.o dtrace-probe.o dummy-frame.o dwarf2= /abbrev-cache.o dwarf2/abbrev.o dwarf2/attribute.o dwarf2/comp-unit-head.o = dwarf2/cooked-index.o dwarf2/cu.o dwarf2/dwz.o dwarf2/expr.o dwarf2/frame-t= ailcall.o dwarf2/frame.o dwarf2/index-cache.o dwarf2/index-common.o dwarf2/= index-write.o dwarf2/leb.o dwarf2/line-header.o dwarf2/loc.o dwarf2/macro.o= dwarf2/read.o dwarf2/section.o dwarf2/stringify.o elf-none-tdep.o elfread.= o eval.o event-top.o exceptions.o exec.o expprint.o extension.o f-exp.o f-l= ang.o f-typeprint.o f-valprint.o filename-seen-cache.o filesystem.o findcmd= =2Eo findvar.o frame-base.o frame-unwind.o frame.o gcore-elf.o gcore.o gdb-= demangle.o gdb_bfd.o gdbarch-selftests.o gdbtypes.o gmp-utils.o gnu-v2-abi.= o gnu-v3-abi.o go-exp.o go-lang.o go-typeprint.o go-valprint.o guile/guile.= o inf-child.o inf-loop.o infcall.o infcmd.o inferior.o inflow.o infrun.o in= line-frame.o interps.o jit.o language.o linespec.o linux-tdep.o location.o = m2-exp.o m2-lang.o m2-typeprint.o m2-valprint.o macrocmd.o macroexp.o macro= scope.o macrotab.o main.o maint-test-options.o maint-test-settings.o maint.= o mdebugread.o mem-break.o memattr.o memory-map.o memrange.o memtag.o mi/mi= -cmd-break.o mi/mi-cmd-catch.o mi/mi-cmd-disas.o mi/mi-cmd-env.o mi/mi-cmd-= file.o mi/mi-cmd-info.o mi/mi-cmd-stack.o mi/mi-cmd-target.o mi/mi-cmd-var.= o mi/mi-cmds.o mi/mi-common.o mi/mi-console.o mi/mi-getopt.o mi/mi-interp.o= mi/mi-main.o mi/mi-out.o mi/mi-parse.o mi/mi-symbol-cmds.o minidebug.o min= syms.o mipsread.o namespace.o objc-lang.o objfiles.o observable.o opencl-la= ng.o osabi.o osdata.o p-exp.o p-lang.o p-typeprint.o p-valprint.o parse.o p= osix-hdep.o printcmd.o probe.o process-stratum-target.o producer.o progspac= e-and-thread.o progspace.o prologue-value.o psymtab.o python/python.o raven= scar-thread.o record-btrace.o record-full.o record.o regcache-dump.o regcac= he.o reggroups.o remote-fileio.o remote-notif.o remote-sim.o remote.o rever= se.o run-on-main-thread.o rust-lang.o rust-parse.o selftest-arch.o sentinel= -frame.o ser-base.o ser-event.o ser-pipe.o ser-tcp.o ser-uds.o ser-unix.o s= erial.o skip.o solib-svr4.o solib-target.o solib.o source-cache.o source.o = sparc-linux-tdep.o sparc-ravenscar-thread.o sparc-tdep.o sparc64-linux-tdep= =2Eo sparc64-tdep.o split-name.o stabsread.o stack.o stap-probe.o std-regs.= o symfile-debug.o symfile-mem.o symfile.o symmisc.o symtab.o target-connect= ion.o target-dcache.o target-descriptions.o target-float.o target-memory.o = target.o target/target.o target/waitstatus.o test-target.o thread-iter.o th= read.o tid-parse.o top.o tracectf.o tracefile-tfile.o tracefile.o tracepoin= t.o trad-frame.o tramp-frame.o tui/tui-command.o tui/tui-data.o tui/tui-dis= asm.o tui/tui-file.o tui/tui-hooks.o tui/tui-interp.o tui/tui-io.o tui/tui-= layout.o tui/tui-location.o tui/tui-out.o tui/tui-regs.o tui/tui-source.o t= ui/tui-stack.o tui/tui-win.o tui/tui-wingeneral.o tui/tui-winsource.o tui/t= ui.o type-stack.o typeprint.o ui-file.o ui-out.o ui-style.o unittests/array= -view-selftests.o unittests/child-path-selftests.o unittests/cli-utils-self= tests.o unittests/command-def-selftests.o unittests/common-utils-selftests.= o unittests/copy_bitwise-selftests.o unittests/enum-flags-selftests.o unitt= ests/environ-selftests.o unittests/filtered_iterator-selftests.o unittests/= format_pieces-selftests.o unittests/function-view-selftests.o unittests/gdb= _tilde_expand-selftests.o unittests/gmp-utils-selftests.o unittests/intrusi= ve_list-selftests.o unittests/lookup_name_info-selftests.o unittests/main-t= hread-selftests.o unittests/memory-map-selftests.o unittests/memrange-selft= ests.o unittests/mkdir-recursive-selftests.o unittests/observable-selftests= =2Eo unittests/offset-type-selftests.o unittests/optional-selftests.o unitt= ests/packed-selftests.o unittests/parallel-for-selftests.o unittests/parse-= connection-spec-selftests.o unittests/path-join-selftests.o unittests/ptid-= selftests.o unittests/rsp-low-selftests.o unittests/scoped_fd-selftests.o u= nittests/scoped_ignore_signal-selftests.o unittests/scoped_mmap-selftests.o= unittests/scoped_restore-selftests.o unittests/search-memory-selftests.o u= nittests/string_view-selftests.o unittests/style-selftests.o unittests/trac= epoint-selftests.o unittests/tui-selftests.o unittests/ui-file-selftests.o = unittests/unique_xmalloc_ptr_char.o unittests/unpack-selftests.o unittests/= utils-selftests.o unittests/vec-utils-selftests.o unittests/xml-utils-selft= ests.o user-regs.o utils.o valarith.o valops.o valprint.o value.o varobj.o = version.o xml-builtin.o xml-support.o xml-syscall.o xml-tdesc.o init.o \ ../sim/erc32/libsim.a ../readline/readline/libreadline.a ../opcod= es/libopcodes.a ../libctf/.libs/libctf.a ../bfd/libbfd.a -L./../zlib -lz ..= /gdbsupport/libgdbsupport.a ../libiberty/libiberty.a ../libdecnumber/libde= cnumber.a ../libbacktrace/.libs/libbacktrace.a -lncursesw -lm -ldl = =2E./gnulib/import/libgnu.a -lgmp =20 /usr/bin/ld: ../sim/erc32/libsim.a(interf.o): in function `sim_open': /var/cache/git/binutils-gdb/sim/erc32/interf.c:247: undefined reference to = `fprintf_styled' collect2: error: ld returned 1 exit status make[1]: *** [Makefile:2142: gdb] Error 1 make[1]: Leaving directory '/tmp/sparc/b/gdb' make: *** [Makefile:13193: all-gdb] Error 2 erc32 has two INIT_DISASSEMBLE_INFO(), of which one doesn't pick the provided function. Maybe just ordering? MfG, JBG --=20 --ylxaiclprgzfahrw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQQlDTvPcScNjKREqWEdvV51g5nhuwUCYxL62AAKCRAdvV51g5nh u/D/AJ4vUfahOkK1uhNSp6bWfJgbFYliVQCeIcJ8HCueXzYZ/L7kjPspAIlQuCw= =t7vr -----END PGP SIGNATURE----- --ylxaiclprgzfahrw--