From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by sourceware.org (Postfix) with ESMTPS id C5FF83858403 for ; Wed, 7 Sep 2022 14:45:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C5FF83858403 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 0D7D1204E0; Wed, 7 Sep 2022 14:45:43 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E9D7B13A66; Wed, 7 Sep 2022 14:45:42 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id l/DHN5auGGPtSgAAMHmgww (envelope-from ); Wed, 07 Sep 2022 14:45:42 +0000 Date: Wed, 7 Sep 2022 16:45:41 +0200 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH][gdb/testsuite] xfail gdb.ada/O2_float_param.exp for aarch64 and gcc 7.5.0 Message-ID: <20220907144539.GA3288@delia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_NUMSUBJECT, KAM_SHORT, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Sep 2022 14:45:46 -0000 Hi, On aarch64-linux, with gcc 7.5.0, we run into: ... (gdb) frame^M #0 callee.increment (val=99.0, val@entry=9.18340949e-41, msg=...) at \ callee.adb:21^M 21 if Val > 200.0 then^M (gdb) FAIL: gdb.ada/O2_float_param.exp: scenario=all: frame ... The problem is a GCC bug, filed as "PR98148 - [AArch64] Wrong location expression for function entry values" ( https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98148 ). Xfail the test for aarch64 and gcc 7. Tested on x86_64-linux and aarch64-linux. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=29418 Any comments? Thanks, - Tom [gdb/testsuite] xfail gdb.ada/O2_float_param.exp for aarch64 and gcc 7.5.0 --- gdb/testsuite/gdb.ada/O2_float_param.exp | 24 +++++++++++++++++++++++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/gdb/testsuite/gdb.ada/O2_float_param.exp b/gdb/testsuite/gdb.ada/O2_float_param.exp index 0c2969e0c4f..062a27572f5 100644 --- a/gdb/testsuite/gdb.ada/O2_float_param.exp +++ b/gdb/testsuite/gdb.ada/O2_float_param.exp @@ -19,6 +19,13 @@ if { [skip_ada_tests] } { return -1 } standard_ada_testfile foo +set have_xfail 0 +if { [is_aarch64_target] } then { + if { [gcc_major_version] <= 8 } { + set have_xfail 1 + } +} + foreach_with_prefix scenario {all minimal} { set flags [list debug \ optimize=-O2 \ @@ -32,6 +39,21 @@ foreach_with_prefix scenario {all minimal} { runto "increment" - gdb_test "frame" \ + set re \ "#0\\s+callee\\.increment \\(val(=val@entry)?=99\\.0, msg=\\.\\.\\.\\).*" + set re_different_entry_val \ + "#0\\s+callee\\.increment \\(val=99.0, val@entry=.*, msg=\\.\\.\\.\\).*" + gdb_test_multiple "frame" "" { + -re -wrap $re { + pass $gdb_test_name + } + -re -wrap $re_different_entry_val { + if { $have_xfail } { + # GCC PR98148 + xfail $gdb_test_name + } else { + fail $gdb_test_name + } + } + } }