From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x2c.google.com (mail-oa1-x2c.google.com [IPv6:2001:4860:4864:20::2c]) by sourceware.org (Postfix) with ESMTPS id 6B6683858D28 for ; Thu, 8 Sep 2022 06:42:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6B6683858D28 Received: by mail-oa1-x2c.google.com with SMTP id 586e51a60fabf-127dca21a7dso14632729fac.12 for ; Wed, 07 Sep 2022 23:42:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=PYQ8+HtQMtB0Nh6fhL67Tq27IE7l2Yxf974+UGa0IZk=; b=b4dmhv+s9oiNbpDHC3wS+YKAL+/lMbr5CU5BaCh2+qIPD8iRglnGpo1gXGj6+lXl05 A41m3dndP0snc1WbvsuNYn0ZdSF3bXDSXAa4Yn1ZTVdeq3OFpxU+Yk+TsfI/mDYePIiA mHd92/xk18lSLVZ+gEBI/asv7c/2GCWz7mTupfdmQ5Syug/t0EZD/zHHkt4koWotgy+f TQPDc/+usGEVmb+iLAAaF8lFv1JJd59x3VlM7XbXowXHv8c9iVO+YdrioxMEVPGlyacG bDrF5XROSrRDt7yCzG3dGeAhRdp0jKmT1ADNtLl1qOdmnVBzfPloJO/qSNcJh0jRGvel Y0CQ== X-Gm-Message-State: ACgBeo1Y1Nj6tAxoybkkoU3RtK+R7OMjbL0eQqW/+H/x+5j7B7zQjcd6 C+2Y0y7nx4O3MVFEK95GC/tQ59hNds7zVw== X-Google-Smtp-Source: AA6agR5oWMSxjVGqq4KfycmAz6iMUvnIIk6H9uVyd/ulw/OzGT+AC0N88Aitya1YKtLNMvHuoSW9dQ== X-Received: by 2002:a05:6808:138d:b0:344:973a:366c with SMTP id c13-20020a056808138d00b00344973a366cmr844656oiw.134.1662619367844; Wed, 07 Sep 2022 23:42:47 -0700 (PDT) Received: from localhost ([2804:14d:7e39:8470:8eab:4efc:ca3b:b046]) by smtp.gmail.com with ESMTPSA id 43-20020a9d062e000000b0063695ad0cbesm7923710otn.66.2022.09.07.23.42.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Sep 2022 23:42:47 -0700 (PDT) From: Thiago Jung Bauermann To: gdb-patches@sourceware.org Cc: Thiago Jung Bauermann Subject: [PATCH 1/8] gdbserver: Add asserts in register_size and register_data functions Date: Thu, 8 Sep 2022 06:41:44 +0000 Message-Id: <20220908064151.3959930-2-thiago.bauermann@linaro.org> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20220908064151.3959930-1-thiago.bauermann@linaro.org> References: <20220908064151.3959930-1-thiago.bauermann@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-10.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Sep 2022 06:42:49 -0000 These helped me during development, catching bugs closer to when they actually happened. --- gdbserver/regcache.cc | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/gdbserver/regcache.cc b/gdbserver/regcache.cc index 27491efc52d5..ebaeb5e86895 100644 --- a/gdbserver/regcache.cc +++ b/gdbserver/regcache.cc @@ -286,6 +286,8 @@ register_cache_size (const struct target_desc *tdesc) int register_size (const struct target_desc *tdesc, int n) { + gdb_assert (n >= 0 && n < tdesc->reg_defs.size ()); + return find_register_by_number (tdesc, n).size / 8; } @@ -300,6 +302,8 @@ regcache_register_size (const struct regcache *regcache, int n) static unsigned char * register_data (const struct regcache *regcache, int n) { + gdb_assert(n >= 0 && n < regcache->tdesc->reg_defs.size()); + return (regcache->registers + find_register_by_number (regcache->tdesc, n).offset / 8); }