From: Kevin Buettner <kevinb@redhat.com>
To: gdb-patches@sourceware.org
Cc: Tom de Vries <tdevries@suse.de>
Subject: Re: [PATCH][gdb/symtab] Fix handling of DW_TAG_unspecified_type
Date: Sat, 10 Sep 2022 15:02:15 -0700 [thread overview]
Message-ID: <20220910150215.6f326aa7@f35-zws-1> (raw)
In-Reply-To: <20220908130531.GA19459@delia>
On Thu, 8 Sep 2022 15:05:32 +0200
Tom de Vries <tdevries@suse.de> wrote:
> Currently, the test-case contained in this patch fails:
> ...
> (gdb) p (int) foo ()^M
> Invalid cast.^M
> (gdb) FAIL: gdb.dwarf2/dw2-unspecified-type.exp: p (int) foo ()
> ...
> because DW_TAG_unspecified_type is translated as void.
>
> There's some code in read_unspecified_type that marks the type as stub, but
> that's only active for ada:
> ...
> if (cu->lang () == language_ada)
> type->set_is_stub (true);
> ...
>
> Fix this by:
> - marking the type as a stub for all languages, and
> - handling the stub return type case in call_function_by_hand_dummy.
>
> Tested on x86_64-linux.
>
> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=29558
>
> Any comments?
Hi Tom,
Thanks for adding a test and fixing this bug.
LGTM.
Kevin
prev parent reply other threads:[~2022-09-10 22:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-08 13:05 Tom de Vries
2022-09-10 22:02 ` Kevin Buettner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220910150215.6f326aa7@f35-zws-1 \
--to=kevinb@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).