From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 0BE1E385803E for ; Wed, 14 Sep 2022 13:14:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0BE1E385803E Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-93-Rxul76guP2qHiLL8rpJtbA-1; Wed, 14 Sep 2022 09:14:40 -0400 X-MC-Unique: Rxul76guP2qHiLL8rpJtbA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 30FDE8001B8 for ; Wed, 14 Sep 2022 13:14:40 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.40.193.113]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 570801121315; Wed, 14 Sep 2022 13:14:39 +0000 (UTC) From: Bruno Larsen To: gdb-patches@sourceware.org Subject: [PATCH v5 0/7] Clean gdb.base when testing with clang Date: Wed, 14 Sep 2022 15:14:20 +0200 Message-Id: <20220914131427.269689-1-blarsen@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Sep 2022 13:14:43 -0000 When testing GDB with clang, gdb.base had over 50 more failures than when testing with gcc. Examining the failed tests led to a few clang bugs, a few GDB bugs, and many testsuite assumptions that could be changed. After this patch series, nothing should be changed for testing with gcc, and testing with clang should only show non-trivial failures for maint.exp and macscp.exp, along with the same GCC failures. Changes in v5: * Removed patches previously numbered 1,4-11 given Andrew's approval * Split previous patch 3 in two, to make it more focused * Reworded some commits * Dropped patch 13, in favor of Andrew's suggestion (not included). Changes in v4: * Added new test to step through a function's epoligue * renamed gdb_step_until_regexp -> gdb_step_until * small style and wording changes in patches 1 and 2 * Dropped patch 3 - no longer necessary * patch 4 was reworked based on Andrew's suggestion small note, Andrew has OK'd patched 5 and 6 (currently 4 and 5) in v3; Changes in v3: * Fixed some issues that only showed up on CXX_FOR_TARGET=clang * rebased on current master Changes in v2: * Introduced gdb_step_until_regexp, based on Pedro's and Andrew's suggestions * reworked fixes for: skip.exp, skip-solib.exp and msym-bp-shl.exp * Used Pedro's suggestion for call-ar-st * reordered patches slightly Bruno Larsen (7): gdb/testsuite: Add a proc to test where compiler links the epilogue Change gdb.base/skip-solib.exp deal with lack of epilogue information gdb/testsuite: fix testing gdb.base/skip-inline.exp with clang gdb/testsuite: fix gdb.base/msym-bp-shl when running with Clang fix gdb.base/jit-elf.exp when testing with clang gdb.base/skip.exp: Use finish to exit functions gdb/testsuite: Add test to step through function epilogue gdb/testsuite/gdb.base/jit-elf.exp | 2 +- gdb/testsuite/gdb.base/msym-bp-shl-main-2.c | 2 +- gdb/testsuite/gdb.base/skip-inline.exp | 107 ++++++++++-------- gdb/testsuite/gdb.base/skip-solib-lib.c | 3 +- gdb/testsuite/gdb.base/skip-solib-main.c | 3 +- gdb/testsuite/gdb.base/skip.exp | 34 +++--- .../gdb.base/step-through-epilogue.c | 38 +++++++ .../gdb.base/step-through-epilogue.exp | 98 ++++++++++++++++ gdb/testsuite/lib/gdb.exp | 32 ++++++ 9 files changed, 253 insertions(+), 66 deletions(-) create mode 100644 gdb/testsuite/gdb.base/step-through-epilogue.c create mode 100644 gdb/testsuite/gdb.base/step-through-epilogue.exp -- 2.37.3