From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by sourceware.org (Postfix) with ESMTPS id 8A8D5385802B for ; Tue, 20 Sep 2022 17:29:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8A8D5385802B Received: by mail-wr1-x433.google.com with SMTP id s14so3570488wro.0 for ; Tue, 20 Sep 2022 10:29:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=K5h4SaRGqsGLkSwSSjpGv2ygxfWqhjUFmcnt6ULMLLU=; b=fqbBuot4+nqhS22yVTuhswq+HHQuiApLPFlWZD7/lznzO+tqhDib1pKD/Nt4WaFou3 W7i8mMxWZTY6Oi0vOcg7tY6BSbubWjmvogRTFLBK2RPTrwSRfbWx8+MC118crUX2zpk7 WB9c3BtFgM2aCmR+dNcS8nVpSp8C1GO7fPxpNZofilcG/MoxqECEF9ueaQoGtK3Lk5v5 CYM2ZFT9gHjIL0kpjFHmYmUMCiwES/Ue7SBd9qNiJ/mVNlTvDcJEM6NREePaCxeqXvDP aU2rThVbRc77qInh5Pq0snwY6gqIuw0qP/0BdSXyp+ZYnST6JVTDN5cn5Zhc4qIcIlOu Xx7w== X-Gm-Message-State: ACrzQf3Fqb94NOtw2fN2oWzWlFDnxwwtBhsS8c21tD5GlMehvztWPnG2 z35dV4U4HKhS0bGP1TlLUI36xSCvy6KTLA== X-Google-Smtp-Source: AMsMyM5O0K1Qc25g5iWpvG66wvQcunyvWYMjbcJsX2fBKrvmpufLOk2D9sNC/YUPMPqAi0I76untxA== X-Received: by 2002:a05:6000:1566:b0:228:b754:186e with SMTP id 6-20020a056000156600b00228b754186emr14642364wrz.226.1663694968134; Tue, 20 Sep 2022 10:29:28 -0700 (PDT) Received: from ubuntu-22.. (intel10.cs.nthu.edu.tw. [140.114.89.60]) by smtp.gmail.com with ESMTPSA id c1-20020adffb01000000b00228da396f9dsm311685wrr.84.2022.09.20.10.29.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Sep 2022 10:29:27 -0700 (PDT) From: Johnson Sun To: gdb-patches@sourceware.org Cc: j3.soon777@gmail.com Subject: [PATCH 3/3] [gdb/python] Replace gdbpy_should_stop with gdbpy_breakpoint_cond_says_stop Date: Wed, 21 Sep 2022 01:24:28 +0800 Message-Id: <20220920172426.90659-4-j3.soon777@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220920172426.90659-1-j3.soon777@gmail.com> References: <20220920172426.90659-1-j3.soon777@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-10.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Sep 2022 17:29:30 -0000 In 2014, the function `gdbpy_should_stop' has been replaced with `gdbpy_breakpoint_cond_says_stop' This replaces `gdbpy_should_stop' with `gdbpy_breakpoint_cond_says_stop' in the comments. Since `gdbpy_should_stop' has been renamed as noted in `gdb/ChangeLog-2014': * python/py-breakpoint.c (gdbpy_breakpoint_cond_says_stop): Renamed from gdbpy_should_stop. Change result type to enum scr_bp_stop. --- gdb/python/py-finishbreakpoint.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gdb/python/py-finishbreakpoint.c b/gdb/python/py-finishbreakpoint.c index a219bc82f15..d608c95be0f 100644 --- a/gdb/python/py-finishbreakpoint.c +++ b/gdb/python/py-finishbreakpoint.c @@ -90,7 +90,7 @@ bpfinishpy_dealloc (PyObject *self) Py_TYPE (self)->tp_free (self); } -/* Triggered when gdbpy_should_stop is about to execute the `stop' callback +/* Triggered when gdbpy_breakpoint_cond_says_stop is about to execute the `stop' callback of the gdb.FinishBreakpoint object BP_OBJ. Will compute and cache the `return_value', if possible. */ @@ -134,7 +134,7 @@ bpfinishpy_pre_stop_hook (struct gdbpy_breakpoint_object *bp_obj) } } -/* Triggered when gdbpy_should_stop has triggered the `stop' callback +/* Triggered when gdbpy_breakpoint_cond_says_stop has triggered the `stop' callback of the gdb.FinishBreakpoint object BP_OBJ. */ void -- 2.34.1