From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lsix@lancelotsix.com>
Received: from lndn.lancelotsix.com (lndn.lancelotsix.com [51.195.220.111])
 by sourceware.org (Postfix) with ESMTPS id E123F3856959
 for <gdb-patches@sourceware.org>; Wed, 21 Sep 2022 14:37:56 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E123F3856959
Received: from ubuntu.lan (unknown [IPv6:2a02:390:9086::635])
 by lndn.lancelotsix.com (Postfix) with ESMTPSA id BDB2481141;
 Wed, 21 Sep 2022 14:37:55 +0000 (UTC)
Date: Wed, 21 Sep 2022 14:37:50 +0000
From: Lancelot SIX <lsix@lancelotsix.com>
To: Simon Marchi <simon.marchi@efficios.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/4] gdb: remove TYPE_TARGET_TYPE
Message-ID: <20220921143750.pkzms5alxkvhtcwf@ubuntu.lan>
References: <20220916150836.527213-1-simon.marchi@efficios.com>
 <20220916150836.527213-2-simon.marchi@efficios.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220916150836.527213-2-simon.marchi@efficios.com>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.11
 (lndn.lancelotsix.com [0.0.0.0]); Wed, 21 Sep 2022 14:37:55 +0000 (UTC)
X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Wed, 21 Sep 2022 14:37:59 -0000

Hi,

When applying it locally, I have:

    Applying: gdb: remove TYPE_TARGET_TYPE
    .git/rebase-apply/patch:4243: space before tab in indent.
                                current_type = current_type->target_type ();
    warning: 1 line adds whitespace errors.

On Fri, Sep 16, 2022 at 11:08:34AM -0400, Simon Marchi via Gdb-patches wrote:
> From: Simon Marchi <simon.marchi@polymtl.ca>
> 
> Remove the macro, replace all uses by calls to type::length.
                                                       ^
I think you meant type::target_type here.

Also after applying the patch, git grep TYPE_TARGET_TYPE gives me:

    gdb/ada-lang.c:   the result of this function in the TYPE_TARGET_TYPE of the
    gdb/c-typeprint.c:       couldn't resolve TYPE_TARGET_TYPE.  Not much we can do.  */
    gdb/gdbtypes.c:   NOTE: This will return a typedef if TYPE_TARGET_TYPE for the typedef has
    gdb/m2-typeprint.c:      /* FIXME: TYPE_TARGET_TYPE used to be TYPE_DOMAIN_TYPE but that was
    gdb/m2-typeprint.c:      wrong.  Not sure if TYPE_TARGET_TYPE is correct though.  */
    gdb/m2-typeprint.c:       *  type of _m2_contents is a pointer.  The TYPE_TARGET_TYPE

All those occurrences are in comments, but I think that it would help
future readers to update those new spots as well.

Otherwise, and for what it is worth considering I am not a maintainer,
this looks reasonable to me.  Thanks for taking the time to make those
tree-wide changes!

Lancelot.