From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lsix@lancelotsix.com>
Received: from lndn.lancelotsix.com (vps-42846194.vps.ovh.net
 [IPv6:2001:41d0:801:2000::2400])
 by sourceware.org (Postfix) with ESMTPS id BD8CC385742D
 for <gdb-patches@sourceware.org>; Fri, 23 Sep 2022 07:58:43 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BD8CC385742D
Received: from ubuntu.lan (cust120-dsl54.idnet.net [212.69.54.120])
 by lndn.lancelotsix.com (Postfix) with ESMTPSA id AB6858758D;
 Fri, 23 Sep 2022 07:58:42 +0000 (UTC)
Date: Fri, 23 Sep 2022 07:58:07 +0000
From: Lancelot SIX <lsix@lancelotsix.com>
To: Luis Machado <luis.machado@arm.com>
Cc: thiago.bauermann@linaro.org, gdb-patches@sourceware.org
Subject: Re: [PATCH,v3] [aarch64] Fix removal of non-address bits for PAuth
Message-ID: <20220923075807.6pffexs3kncrk6qo@ubuntu.lan>
References: <20220705140037.135012-1-luis.machado@arm.com>
 <20220823202936.1561526-1-luis.machado@arm.com>
 <20220922125805.hvekyxcf3nc2i764@ubuntu.lan>
 <b79d6348-af57-9734-ce40-c4eca6cc0e06@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <b79d6348-af57-9734-ce40-c4eca6cc0e06@arm.com>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.11
 (lndn.lancelotsix.com [0.0.0.0]); Fri, 23 Sep 2022 07:58:42 +0000 (UTC)
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_SBL_CSS, SPF_HELO_NONE,
 SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Fri, 23 Sep 2022 07:58:45 -0000

> 
> If either one of the register reads fail, then we assign the default MASK. Otherwise we
> continue with using the mask that's been read from the register.
> 
> Does that make sense?
> 

Yes of curse, I have no idea how I read this wrong.  My bad.  Sorry for
the noise.

> 
> Although this is only used on Linux systems at the moment, it is not technically Linux-specific.
> 
> When we say kernel-space, it means the other half of the VA space (non-user).
> 
> I have an upcoming patch (relying on this one) to use this function for bare metal pointer authentication
> support (with user QEMU). So I think it makes sense to have this function in arch-specific code
> and not in Linux-specific code.
> 

Thanks, for the clarification.

As far as I can tell, this looks reasonable, I’ll leave it to a
maintainer to approve.

Best,
Lanelot.