From: Fangrui Song <maskray@google.com>
To: Enze Li <enze.li@hotmail.com>
Cc: Fangrui Song via Gdb-patches <gdb-patches@sourceware.org>,
Alan Modra <amodra@gmail.com>, Jan Beulich <jbeulich@suse.com>,
Nick Clifton <nickc@redhat.com>,
Simon Marchi <simon.marchi@polymtl.ca>,
binutils@sourceware.org
Subject: Re: [PATCH v3] binutils, gdb: support zstd compressed debug sections
Date: Sat, 24 Sep 2022 00:13:37 -0700 [thread overview]
Message-ID: <20220924071337.6shhf26p7vbqkcjj@google.com> (raw)
In-Reply-To: <OS3P286MB2152206F3272CCBA30F52370F0509@OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM>
On 2022-09-24, Enze Li wrote:
>Hi Fangrui,
>
>One nit, maybe not an important one.
>
>A proper committed message should include a link to the relevant bug on
>Bugzilla. Like this,
>
> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=29563
>
>For more detail, see here[1].
>
>[1] https://sourceware.org/gdb/wiki/ContributionChecklist#Properly_formatted_commit_messages
>
>Thanks,
>Enze
Hi Enze,
Thanks for the notice. I see that gdb started to use "Bug:" since 2021-07.
In binutils, there isn't such a convention and there is no commit using
"Bug:". So I will keep using the umbrella link PR29397.
I am on the
fence whether the gdb one needs to use "Bug:" but I'll probably not use
it this time. Ideally the gdb patch should be separate, but since the
bfd's zstd dependency needs gdb build system's cooperation it is placed
in the same patch:)
I am still waiting for an approval from binutils side. Relatedly, I
believe ChangeLog is no longer strictly enforced. There are many recent
commits don't using ChangeLog. I intentionally skip ChangeLog for this
patch since I believe it would provide little value. (I see
"ANNOUNCEMENT: ChangeLog policy change after GDB 11".)
next prev parent reply other threads:[~2022-09-24 7:13 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-23 4:08 Fangrui Song
2022-09-23 14:32 ` Simon Marchi
2022-09-26 5:12 ` Alan Modra
2022-09-26 7:20 ` Fangrui Song
2022-09-26 13:30 ` Alan Modra
2022-09-26 14:08 ` Simon Marchi
2022-09-27 0:33 ` Alan Modra
2022-09-23 15:45 ` Nick Clifton
2022-09-23 15:58 ` Simon Marchi
2022-09-23 18:20 ` Fangrui Song
2022-09-23 18:57 ` Simon Marchi
2022-09-23 20:34 ` Fangrui Song
2022-09-24 5:43 ` Eli Zaretskii
2022-09-24 6:53 ` Enze Li
2022-09-24 7:13 ` Fangrui Song [this message]
2022-09-27 18:06 ` Tom Tromey
2022-09-27 18:08 ` Tom Tromey
2022-09-27 18:53 ` Fangrui Song
2022-09-28 11:52 ` [PATCH] Fix GDB build: ELF support check & -lzstd (was: Re: [PATCH v3] binutils, gdb: support zstd compressed debug sections) Pedro Alves
2022-09-28 19:00 ` Simon Marchi
2022-09-28 19:27 ` Pedro Alves
2022-09-28 19:30 ` Fangrui Song
2022-09-29 18:30 ` Pedro Alves
2022-09-29 11:43 ` [PATCH v3] binutils, gdb: support zstd compressed debug sections Martin Liška
2022-09-29 20:17 ` Fangrui Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220924071337.6shhf26p7vbqkcjj@google.com \
--to=maskray@google.com \
--cc=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=enze.li@hotmail.com \
--cc=gdb-patches@sourceware.org \
--cc=jbeulich@suse.com \
--cc=nickc@redhat.com \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).