From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id CD2ED396E877 for ; Sat, 8 Oct 2022 04:36:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CD2ED396E877 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-121-Kj5tl1CUMEOxjBkDgoP84w-1; Sat, 08 Oct 2022 00:36:53 -0400 X-MC-Unique: Kj5tl1CUMEOxjBkDgoP84w-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6E5671C06EE0; Sat, 8 Oct 2022 04:36:53 +0000 (UTC) Received: from f35-zws-1 (unknown [10.2.16.76]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0226A9D494; Sat, 8 Oct 2022 04:36:52 +0000 (UTC) Date: Fri, 7 Oct 2022 21:36:51 -0700 From: Kevin Buettner To: Carl Love via Gdb-patches Cc: Carl Love , Ulrich Weigand Subject: Re: [PATCH 2/2] PowerPC, fix support for printing the function return value for non-trivial values. Message-ID: <20221007213651.7519c80b@f35-zws-1> In-Reply-To: <1d55efe113cdcf96b812055ee45196a554c4ca78.camel@us.ibm.com> References: <28ce795ca489f69829207b2a7a535cf7f77f6dd8.camel@us.ibm.com> <8decd662134d57e8caf43960a1cdc47723e2bfe3.camel@us.ibm.com> <79d82ed277308ed5ce312bff398e770ab234390a.camel@us.ibm.com> <63f21a897f452d81a73fb386cb99110a359ef0b7.camel@de.ibm.com> <97275f61ef101a12cde8e5a45008ed8e479424eb.camel@us.ibm.com> <191f5826b228a7614c084c9704b086851d418c78.camel@us.ibm.com> <5405a79ecd6ed34646ad77eed0779063ee222d37.camel@de.ibm.com> <1d55efe113cdcf96b812055ee45196a554c4ca78.camel@us.ibm.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 Oct 2022 04:36:56 -0000 Hi Carl, I'm still working through the patch, but I noticed what I believe to be incorrect terminology while reading the intro / commit log... On Thu, 06 Oct 2022 09:37:40 -0700 Carl Love via Gdb-patches wrote: ... > This patch adds a new gdb ABI to allow PowerPC to access the value of r3 > on entry to a function. The new gdb ABI attempts to use the DW_OP_entry ... Rather than saying "gdb ABI", I think you meant to say "gdbarch method". Also, I'd say something like "On PowerPC, the new gdbarch method attempts to use DW_OP_entry...". (I.e., this new method doesn't attempt to access r3 on all architectures.) Kevin