From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id CAEE03850859 for ; Wed, 12 Oct 2022 08:56:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CAEE03850859 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D55BD21994 for ; Wed, 12 Oct 2022 08:56:06 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id BD8E713ACD for ; Wed, 12 Oct 2022 08:56:06 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id HgAZLSaBRmN5aAAAMHmgww (envelope-from ) for ; Wed, 12 Oct 2022 08:56:06 +0000 Date: Wed, 12 Oct 2022 10:56:05 +0200 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [committed][gdb/contrib] Use OBJCOPY everywhere in cc-with-tweaks.sh Message-ID: <20221012085602.GA22064@delia.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Oct 2022 08:56:09 -0000 Hi, I noticed that the $want_gnu_debuglink code in gdb/contrib/cc-with-tweaks.sh uses objcopy instead of $OBJCOPY. Fix this. Script checked with shellcheck, no new warnings added. Tested on x86_64-linux. Committed to trunk. Thanks, - Tom [gdb/contrib] Use OBJCOPY everywhere in cc-with-tweaks.sh --- gdb/contrib/cc-with-tweaks.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/contrib/cc-with-tweaks.sh b/gdb/contrib/cc-with-tweaks.sh index 7919d2da85a..c6f0f62cd06 100755 --- a/gdb/contrib/cc-with-tweaks.sh +++ b/gdb/contrib/cc-with-tweaks.sh @@ -285,7 +285,7 @@ if [ "$want_gnu_debuglink" = true ]; then # Overwrite output_file with stripped version containing # .gnu_debuglink to debug_file. - objcopy --add-gnu-debuglink="$link" "${stripped_file}" \ + $OBJCOPY --add-gnu-debuglink="$link" "${stripped_file}" \ "${output_file}" rc=$? [ $rc != 0 ] && exit $rc