From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id 9D99B38207C9 for ; Wed, 12 Oct 2022 15:03:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9D99B38207C9 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D0BEB21B72 for ; Wed, 12 Oct 2022 15:03:34 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B803213ACD for ; Wed, 12 Oct 2022 15:03:34 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id jn7hKkbXRmNrNAAAMHmgww (envelope-from ) for ; Wed, 12 Oct 2022 15:03:34 +0000 Date: Wed, 12 Oct 2022 17:03:33 +0200 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [committed][gdb/testsuite] Fix ctf test-cases on openSUSE Tumbleweed Message-ID: <20221012150331.GA5059@delia.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Oct 2022 15:03:37 -0000 Hi, When running test-case gdb.base/ctf-constvars.exp on openSUSE Tumbleweed (with system gcc version 12, providing gcc -gctf support, enabling the ctf test-cases in the gdb testsuite), I run into: ... (gdb) print vox^M 'vox' has unknown type; cast it to its declared type^M (gdb) FAIL: gdb.base/ctf-constvars.exp: print vox ... There are two causes for this: - the linker flags are missing --ctf-variables, so the information for variable vox is missing (reported in PR29468), and - the executable contains some dwarf2 due to some linked-in glibc objects, so the ctf info is ignored (reported in PR29160). By using: - -Wl,--ctf-variable, - -Wl,--strip-debug, and we can make the test-case and some similar test-cases pass. Tested on x86_64-linux. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=29160 Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=29468 Committed to trunk. Thanks, - Tom [gdb/testsuite] Fix ctf test-cases on openSUSE Tumbleweed --- gdb/testsuite/gdb.base/ctf-constvars.exp | 9 +++++++-- gdb/testsuite/gdb.base/ctf-ptype.exp | 8 ++++++-- gdb/testsuite/gdb.base/cvexpr.exp | 6 +++++- gdb/testsuite/gdb.base/whatis.exp | 7 ++++++- gdb/testsuite/gdb.ctf/cross-tu-cyclic.exp | 9 +++++++-- gdb/testsuite/gdb.ctf/funcreturn.exp | 8 ++++++-- gdb/testsuite/gdb.ctf/multi.exp | 9 +++++++-- 7 files changed, 44 insertions(+), 12 deletions(-) diff --git a/gdb/testsuite/gdb.base/ctf-constvars.exp b/gdb/testsuite/gdb.base/ctf-constvars.exp index 6255e9ed02b..a5e7fe0b015 100644 --- a/gdb/testsuite/gdb.base/ctf-constvars.exp +++ b/gdb/testsuite/gdb.base/ctf-constvars.exp @@ -32,9 +32,14 @@ if [skip_ctf_tests] { standard_testfile .c # Using `-gctf` generates full-fledged CTF debug information. -set opts "additional_flags=-gctf" +set opts {} +lappend opts additional_flags=-gctf +lappend opts ldflags=-Wl,--strip-debug +lappend opts ldflags=-Wl,--ctf-variables +lappend opts nowarnings + if { [prepare_for_testing "failed to prepare" ${testfile} \ - [list $srcfile] [list $opts nowarnings]] } { + [list $srcfile] $opts] } { return 0 } diff --git a/gdb/testsuite/gdb.base/ctf-ptype.exp b/gdb/testsuite/gdb.base/ctf-ptype.exp index 48d39e56c7b..28deabb6ac5 100644 --- a/gdb/testsuite/gdb.base/ctf-ptype.exp +++ b/gdb/testsuite/gdb.base/ctf-ptype.exp @@ -26,10 +26,14 @@ set gcc_compiled [is_c_compiler_gcc] standard_testfile .c # Using `-gctf` generates full-fledged CTF debug information. -set opts "additional_flags=-gctf" +set opts {} +lappend opts additional_flags=-gctf +lappend opts ldflags=-Wl,--strip-debug +lappend opts ldflags=-Wl,--ctf-variables +lappend opts nowarnings if { [prepare_for_testing "failed to prepare" ${testfile} \ - [list $srcfile] [list $opts nowarnings]] } { + [list $srcfile] $opts] } { return 0 } diff --git a/gdb/testsuite/gdb.base/cvexpr.exp b/gdb/testsuite/gdb.base/cvexpr.exp index d8437b94c61..272efaff97c 100644 --- a/gdb/testsuite/gdb.base/cvexpr.exp +++ b/gdb/testsuite/gdb.base/cvexpr.exp @@ -491,10 +491,14 @@ proc do_test {dir options} { # } +set ctf_opts {} +lappend ctf_opts additional_flags=-gctf +lappend ctf_opts ldflags=-Wl,--strip-debug + # Build up the set of debug formats for which we will run this test. set specs { {dwarf {debug}} } if ![skip_ctf_tests] { - lappend specs {ctf {"additional_flags=-gctf"}} + lappend specs [list ctf $ctf_opts] } # Setup and run the test for each debug format. diff --git a/gdb/testsuite/gdb.base/whatis.exp b/gdb/testsuite/gdb.base/whatis.exp index c19c149f012..5a3ff536bd9 100644 --- a/gdb/testsuite/gdb.base/whatis.exp +++ b/gdb/testsuite/gdb.base/whatis.exp @@ -585,10 +585,15 @@ proc do_test {dir options} { "whatis applied to function with 'void' parameter type" } +set ctf_opts {} +lappend ctf_opts additional_flags=-gctf +lappend ctf_opts ldflags=-Wl,--strip-debug +lappend ctf_opts ldflags=-Wl,--ctf-variables + # Build up the set of debug formats for which we will run this test. set specs { {dwarf {debug}} } if ![skip_ctf_tests] { - lappend specs {ctf {"additional_flags=-gctf"}} + lappend specs [list ctf $ctf_opts] } # Setup and run the test for each debug format. diff --git a/gdb/testsuite/gdb.ctf/cross-tu-cyclic.exp b/gdb/testsuite/gdb.ctf/cross-tu-cyclic.exp index a43e36bbe68..ca11b739ed8 100644 --- a/gdb/testsuite/gdb.ctf/cross-tu-cyclic.exp +++ b/gdb/testsuite/gdb.ctf/cross-tu-cyclic.exp @@ -24,10 +24,15 @@ standard_testfile cross-tu-cyclic-1.c cross-tu-cyclic-2.c \ cross-tu-cyclic-3.c cross-tu-cyclic-4.c # Using `-gctf` generates full-fledged CTF debug information. -set opts "additional_flags=-gctf -Wl,--export-dynamic" +set opts {} +lappend opts additional_flags=-gctf +lappend opts ldflags=-Wl,--export-dynamic +lappend opts ldflags=-Wl,--strip-debug +lappend opts nowarning + if { [prepare_for_testing "failed to prepare" ${testfile} \ [list $srcfile $srcfile2 $srcfile3 $srcfile4] \ - [list $opts nowarnings]] } { + $opts] } { return 0 } diff --git a/gdb/testsuite/gdb.ctf/funcreturn.exp b/gdb/testsuite/gdb.ctf/funcreturn.exp index ea01e860a84..1267cab2b75 100644 --- a/gdb/testsuite/gdb.ctf/funcreturn.exp +++ b/gdb/testsuite/gdb.ctf/funcreturn.exp @@ -30,10 +30,14 @@ set gcc_compiled [is_c_compiler_gcc] standard_testfile whatis.c # Using `-gctf` generates full-fledged CTF debug information. -set opts "additional_flags=-gctf -Wl,--export-dynamic" +set opts {} +lappend opts additional_flags=-gctf +lappend opts ldflags=-Wl,--export-dynamic +lappend opts ldflags=-Wl,--strip-debug +lappend opts nowarning if { [prepare_for_testing "failed to prepare" ${testfile} \ - [list $srcfile] [list $opts nowarnings]] } { + [list $srcfile] $opts] } { return 0 } diff --git a/gdb/testsuite/gdb.ctf/multi.exp b/gdb/testsuite/gdb.ctf/multi.exp index 07fd10a884c..93fcbb660a2 100644 --- a/gdb/testsuite/gdb.ctf/multi.exp +++ b/gdb/testsuite/gdb.ctf/multi.exp @@ -23,10 +23,15 @@ if [skip_ctf_tests] { standard_testfile ctf-a.c ctf-b.c ctf-c.c # Using `-gctf` generates full-fledged CTF debug information. -set opts "additional_flags=-gctf -Wl,--export-dynamic" +set opts {} +lappend opts additional_flags=-gctf +lappend opts ldflags=-Wl,--export-dynamic +lappend opts ldflags=-Wl,--strip-debug +lappend opts nowarning + if { [prepare_for_testing "failed to prepare" ${testfile} \ [list $srcfile $srcfile2 $srcfile3] \ - [list $opts nowarnings]] } { + $opts] } { return 0 }