From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id 3BF443860C3C for ; Fri, 14 Oct 2022 11:11:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3BF443860C3C Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 729EE21A28 for ; Fri, 14 Oct 2022 11:11:23 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 591CE13451 for ; Fri, 14 Oct 2022 11:11:23 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id ih12FNtDSWPrWgAAMHmgww (envelope-from ) for ; Fri, 14 Oct 2022 11:11:23 +0000 Date: Fri, 14 Oct 2022 13:11:22 +0200 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [committed][gdb/testsuite] Drop unnecessary -Wl,-soname in gdb.base/skip-solib.exp Message-ID: <20221014111119.GA11309@delia.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Oct 2022 11:11:27 -0000 Hi, I noticed in gdb.base/skip-solib.exp: ... if {[gdb_compile_shlib ${srcdir}/${subdir}/${srcfile_lib} ${binfile_lib} \ [list debug -Wl,-soname,${libname}.so]] != ""} { return -1 } ... that the -Wl,-soname argument is missing an ldflags= prefix, but adding it gives us a duplicate: ... Executing on host: gcc -fno-stack-protector \ outputs/gdb.base/skip-solib/skip-solib-lib.c.o -fdiagnostics-color=never \ -shared -g -Wl,-soname,libskip-solib.so -Wl,-soname,libskip-solib.so -lm \ -o outputs/gdb.base/skip-solib/libskip-solib.so (timeout = 300) ... so apparently it's taken care of by gdb_compile_shlib. Drop the inactive and also unnecessary -Wl,-soname,${libname}.so from the flags list for the gdb_compile_shlib call. Tested on x86_64-linux. Committed to trunk. Thanks, - Tom [gdb/testsuite] Drop unnecessary -Wl,-soname in gdb.base/skip-solib.exp --- gdb/testsuite/gdb.base/skip-solib.exp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/testsuite/gdb.base/skip-solib.exp b/gdb/testsuite/gdb.base/skip-solib.exp index 9af39d829c0..49539bb6695 100644 --- a/gdb/testsuite/gdb.base/skip-solib.exp +++ b/gdb/testsuite/gdb.base/skip-solib.exp @@ -41,7 +41,7 @@ set binfile_lib [standard_output_file ${libname}.so] # if {[gdb_compile_shlib ${srcdir}/${subdir}/${srcfile_lib} ${binfile_lib} \ - [list debug -Wl,-soname,${libname}.so]] != ""} { + [list debug]] != ""} { return -1 }