From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd34.google.com (mail-io1-xd34.google.com [IPv6:2607:f8b0:4864:20::d34]) by sourceware.org (Postfix) with ESMTPS id 363CD385829F for ; Mon, 17 Oct 2022 18:58:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 363CD385829F Received: by mail-io1-xd34.google.com with SMTP id 187so9876456iov.10 for ; Mon, 17 Oct 2022 11:58:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=B12XC/HU9p4rpIYOAbfVPJkUFz4W4pxBRiAewKSDUj4=; b=jgi/CMz3BAtoxYCVuLZU6GpRhTVUbXXwh95u80AFEm2SNrIB51HabXvHmvltDpviaT CV52oG8Cvu9qFZ427E6PyuwjQSPgpkmmFIAMjUtfy77PRRG/sAZ2LADB0sEWaW+Knw52 Fn/0BT+fa2hT4/ddMF7Fapvr2u0x7zfoHDDFsqj1QvsbxAwNJjhthyfC0Mjl783Cxhno wdOnPItKvqWadraqUZouzN2tiUfwQovEH5XKbonYzWNztZSrUmPOAAMbFniKQQWJEXGE G3N2bbQeOPS/16Vm8Qa3sTqUdli1nwp1wgm5zmeRM0l/00iEk8+k8sQr9jQCJ5UbXj8c WKWQ== X-Gm-Message-State: ACrzQf38ZV34kEu81Yi+mdVSMficYzGP4ofHqj43Uk3tRpNLMmSD4VwW 8JqARi+lsK1/2BULScXIrFIGHrrxjKUC/g== X-Google-Smtp-Source: AMsMyM5gwJRF9loQjD014eNfjoN8xEjtPPBbEp8pU9vwCoDpIinzkReZO/+bYuxxz6CL32HhzoouNg== X-Received: by 2002:a6b:cf01:0:b0:6bc:1160:8687 with SMTP id o1-20020a6bcf01000000b006bc11608687mr5062815ioa.47.1666033130435; Mon, 17 Oct 2022 11:58:50 -0700 (PDT) Received: from localhost.localdomain (71-211-181-169.hlrn.qwest.net. [71.211.181.169]) by smtp.gmail.com with ESMTPSA id l25-20020a02cd99000000b003637915c721sm203459jap.157.2022.10.17.11.58.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Oct 2022 11:58:49 -0700 (PDT) From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [pushed] Remove a nullptr check in DWARF scanner Date: Mon, 17 Oct 2022 12:58:39 -0600 Message-Id: <20221017185839.2118992-1-tromey@adacore.com> X-Mailer: git-send-email 2.34.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2022 18:58:52 -0000 In scan_attributes, The DWARF scanner checks whether maybe_defer is nullptr, but this can never happen. This patch removes the check. --- gdb/dwarf2/read.c | 1 - 1 file changed, 1 deletion(-) diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c index 33dfd52b362..b5efcb3cc09 100644 --- a/gdb/dwarf2/read.c +++ b/gdb/dwarf2/read.c @@ -18217,7 +18217,6 @@ cooked_indexer::scan_attributes (dwarf2_per_cu_data *scanning_per_cu, if (new_reader->cu == reader->cu && new_info_ptr > watermark_ptr - && maybe_defer != nullptr && *parent_entry == nullptr) *maybe_defer = form_addr (origin_offset, origin_is_dwz); else if (*parent_entry == nullptr) -- 2.34.3