From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd2e.google.com (mail-io1-xd2e.google.com [IPv6:2607:f8b0:4864:20::d2e]) by sourceware.org (Postfix) with ESMTPS id C83B93858D32 for ; Mon, 17 Oct 2022 19:20:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C83B93858D32 Received: by mail-io1-xd2e.google.com with SMTP id r142so9927876iod.11 for ; Mon, 17 Oct 2022 12:20:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=bSIF1Xab9WmfaRK0rKaJFID+/UBbQWhupw1B3Bu3Fts=; b=ddDd2kfbFbfDwbBGTfh4Q5uJHbPSz8k39BO/qktnCkt6mlNDG65TEF1KPGU8o4Yt8N QTKl1gq1EmxGa/82xNCTAYLjBOZ3JpAdLXzklfyAJEPpERsjZNzN2rlCEW0y77ApK01P SOM5TDUqU1hrUwFEESlexVjnXQYmhk0SFUOh9Z1Mj3/c8wYPThit0/jDSdujmfqdf5G3 ZoXUI2vtQN3/FAWK5Q1bMKgUlhZ/dFlJGGRDuZR4dA1YXyfV/Q6kagP38JORrqKqJQSJ 4UjyrX2aM2j+yCoduAn3YvUFd7FXrbKuHedBwJJSQNSVB1XcyO2Y09au6yahcAK3FvXA YMCg== X-Gm-Message-State: ACrzQf349F3NrJt9c/ftUqyPcJj+YJftmQMpMFHOhy9BXrBzQzd/9e/o r8YTGQFZSvDfDo1ngO66forIdIhEzGjkLw== X-Google-Smtp-Source: AMsMyM4DpajTtafJ26i07x4TYPiGWvDtGxFY6vMVL+cHI/H0qk9gxstEGkb1XHB9+sTvc3yBbplvQA== X-Received: by 2002:a05:6638:4123:b0:363:ce70:87cb with SMTP id ay35-20020a056638412300b00363ce7087cbmr6497713jab.189.1666034431037; Mon, 17 Oct 2022 12:20:31 -0700 (PDT) Received: from localhost.localdomain (71-211-181-169.hlrn.qwest.net. [71.211.181.169]) by smtp.gmail.com with ESMTPSA id m22-20020a056638225600b00352a7f96772sm240541jas.38.2022.10.17.12.20.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Oct 2022 12:20:30 -0700 (PDT) From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [pushed] kfail an Ada test for GCC < 12 Date: Mon, 17 Oct 2022 13:20:21 -0600 Message-Id: <20221017192021.2126527-1-tromey@adacore.com> X-Mailer: git-send-email 2.34.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_NUMSUBJECT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2022 19:20:33 -0000 I noticed one particular Ada test was failing on Fedora 34, but works when I switch to GCC 12. This patch arranges to kfail the test when an older compiler is used. I tested this with GCC 11, 12, and 13. I'm going to check it in. --- gdb/testsuite/gdb.ada/packed_array_assign.exp | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/gdb/testsuite/gdb.ada/packed_array_assign.exp b/gdb/testsuite/gdb.ada/packed_array_assign.exp index eef0d39b6a8..a0240fc17be 100644 --- a/gdb/testsuite/gdb.ada/packed_array_assign.exp +++ b/gdb/testsuite/gdb.ada/packed_array_assign.exp @@ -52,6 +52,12 @@ set re \ "\\(packed_array_assign_w => 23," \ "packed_array_assign_x => 7," \ "packed_array_assign_y => 1\\)\\)"] + +# GNAT >= 12.0 has the needed fix here. +set zeros_expected [expr {![test_compiler_info {gcc-1[2-9]-*}]}] +set all_zeros \ + [string_to_regexp "((packed_array_assign_w => 0, packed_array_assign_x => 0, packed_array_assign_y => 0), (packed_array_assign_w => 0, packed_array_assign_x => 0, packed_array_assign_y => 0), (packed_array_assign_w => 0, packed_array_assign_x => 0, packed_array_assign_y => 0))"] + set re [join $re] gdb_test_multiple $cmd "value of pra" { -re -wrap $re { @@ -60,6 +66,12 @@ gdb_test_multiple $cmd "value of pra" { -re -wrap $kfail_int128support_re { kfail gdb/20991 $gdb_test_name } + -re -wrap $all_zeros { + if {$zeros_expected} { + setup_kfail "GCC 12 needed" *-*-* + } + fail $gdb_test_name + } } set cmd "print pra(1) := pr" -- 2.34.3