From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org
Subject: [pushed] [gdb/testsuite] Fix ERROR in gdb.python/py-breakpoint.exp
Date: Wed, 19 Oct 2022 09:42:20 +0200 [thread overview]
Message-ID: <20221019074220.13619-1-tdevries@suse.de> (raw)
With test-case gdb.python/py-breakpoint.exp I run into:
...
(gdb) ERROR: tcl error sourcing gdb.python/py-breakpoint.exp.
ERROR: can't read "skip_hw_watchpoint_tests_p": no such variable
while executing
"if {$skip_hw_watchpoint_tests_p} {
gdb_test_no_output "set can-use-hw-watchpoints 0" ""
}"
...
Fix this by adding the missing "global skip_hw_watchpoint_tests_p" in two
procs.
Tested on x86_64-linux.
---
gdb/testsuite/gdb.python/py-breakpoint.exp | 2 ++
1 file changed, 2 insertions(+)
diff --git a/gdb/testsuite/gdb.python/py-breakpoint.exp b/gdb/testsuite/gdb.python/py-breakpoint.exp
index 0451562f09b..c3215b13d5c 100644
--- a/gdb/testsuite/gdb.python/py-breakpoint.exp
+++ b/gdb/testsuite/gdb.python/py-breakpoint.exp
@@ -307,6 +307,7 @@ proc_with_prefix test_watchpoints { } {
proc_with_prefix test_bkpt_internal { } {
global srcfile testfile hex decimal
+ global skip_hw_watchpoint_tests_p
# Start with a fresh gdb.
clean_restart ${testfile}
@@ -354,6 +355,7 @@ proc_with_prefix test_bkpt_internal { } {
proc_with_prefix test_bkpt_eval_funcs { } {
global srcfile testfile hex decimal
+ global skip_hw_watchpoint_tests_p
# Start with a fresh gdb.
clean_restart ${testfile}
base-commit: 906f69cf65daa8fee1c1c94a5c2fb221ba02b40d
--
2.35.3
reply other threads:[~2022-10-19 7:42 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221019074220.13619-1-tdevries@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).