From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x534.google.com (mail-pg1-x534.google.com [IPv6:2607:f8b0:4864:20::534]) by sourceware.org (Postfix) with ESMTPS id D57B9384D154 for ; Thu, 20 Oct 2022 18:25:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D57B9384D154 Received: by mail-pg1-x534.google.com with SMTP id u71so311073pgd.2 for ; Thu, 20 Oct 2022 11:25:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lSQ7GRburjeokavlrTWNDYYQty4DhLf/Zn521yb2f+g=; b=5A12ZHIcX8fxHZiXcXkJOue6VWlK2d5EuVM+Cu0WR6YY0vGgLPnr74pHHu/Ey7Fp2D 57OVG9jBCBhPFvaW1njz5MQVVZKLNOnD+8V7IVr6oHsWqeFrsnB1zZp4K5fzSbacGesM bJk3FlmgN+064B59fhLLa+IZDlujv9XPI0nWCWn/Nh8oOjF1y4xSwqdnQ4+qjXZLoGsg F7XIsx/CtFofLMO8IVRpr9LC1hi7HUuViNRCUnk+LG2uZ10JhyEctr1g/17Y0RkRcoOi FGLSJKsaz0QoCOsTcfvl603/Sh/wGFIaMzYn+jaOjgJCPX51vKLsd4FwjyFSH5qGyRDZ 7khQ== X-Gm-Message-State: ACrzQf023NS07aAxBzmyR0gfVXSszukd7vEiRGgJPdA+APlh+B0g0BMZ LAFO+nF+JsKNZuVw3HY36So= X-Google-Smtp-Source: AMsMyM6rlUNpxT5miHWsk6HChX79G5ZHCp1JvTf+TvCZ9Xmi05Wa9upGsWFnMzthlzKmiSumltcL/Q== X-Received: by 2002:a05:6a00:1814:b0:563:6bd7:f9e0 with SMTP id y20-20020a056a00181400b005636bd7f9e0mr14845247pfa.33.1666290343848; Thu, 20 Oct 2022 11:25:43 -0700 (PDT) Received: from ubuntu-22.. (intel10.cs.nthu.edu.tw. [140.114.89.60]) by smtp.gmail.com with ESMTPSA id f7-20020a170902860700b001789ee5c821sm13064958plo.61.2022.10.20.11.25.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Oct 2022 11:25:43 -0700 (PDT) From: Johnson Sun To: BrunoLarsen , gdb-patches@sourceware.org Cc: j3.soon777@gmail.com Subject: [PING] [PATCH v2] [gdb/python] Replace gdbpy_should_stop with gdbpy_breakpoint_cond_says_stop Date: Fri, 21 Oct 2022 02:24:57 +0800 Message-Id: <20221020182456.2701-1-j3.soon777@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220923060027.78902-1-j3.soon777@gmail.com> References: <20220923060027.78902-1-j3.soon777@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-10.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2022 18:25:46 -0000 In 2014, the function `gdbpy_should_stop' has been replaced with `gdbpy_breakpoint_cond_says_stop' This replaces `gdbpy_should_stop' with `gdbpy_breakpoint_cond_says_stop' in the comments. Since `gdbpy_should_stop' has been renamed as noted in `gdb/ChangeLog-2014': * python/py-breakpoint.c (gdbpy_breakpoint_cond_says_stop): Renamed from gdbpy_should_stop. Change result type to enum scr_bp_stop. --- gdb/python/py-finishbreakpoint.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gdb/python/py-finishbreakpoint.c b/gdb/python/py-finishbreakpoint.c index c80096f6810..dcf86317779 100644 --- a/gdb/python/py-finishbreakpoint.c +++ b/gdb/python/py-finishbreakpoint.c @@ -90,7 +90,7 @@ bpfinishpy_dealloc (PyObject *self) Py_TYPE (self)->tp_free (self); } -/* Triggered when gdbpy_should_stop is about to execute the `stop' callback +/* Triggered when gdbpy_breakpoint_cond_says_stop is about to execute the `stop' callback of the gdb.FinishBreakpoint object BP_OBJ. Will compute and cache the `return_value', if possible. */ @@ -134,7 +134,7 @@ bpfinishpy_pre_stop_hook (struct gdbpy_breakpoint_object *bp_obj) } } -/* Triggered when gdbpy_should_stop has triggered the `stop' callback +/* Triggered when gdbpy_breakpoint_cond_says_stop has triggered the `stop' callback of the gdb.FinishBreakpoint object BP_OBJ. */ void -- 2.34.1 base-commit: c99b2113a478a075e8d8f7c3848a92f1ce73f847