From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy4-pub.mail.unifiedlayer.com (gproxy4-pub.mail.unifiedlayer.com [69.89.23.142]) by sourceware.org (Postfix) with ESMTPS id 95E8B3853810 for ; Fri, 21 Oct 2022 16:19:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 95E8B3853810 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw10.mail.unifiedlayer.com (unknown [10.0.90.125]) by progateway6.mail.pro1.eigbox.com (Postfix) with ESMTP id 92A83100463C8 for ; Fri, 21 Oct 2022 16:19:31 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id luk6ok3LqT2g2luk7oAug0; Fri, 21 Oct 2022 16:19:31 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=Pds6Ogtd c=1 sm=1 tr=0 ts=6352c693 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=Qawa6l4ZSaYA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=SVklZtLC72kneweBvpcA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject: Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=0NAYo/i7+Rd5OuBnSnT49azfF9QMrNyE4CHTtkTvGAQ=; b=Ob2/IiIilm7rdM0XZfsLqBOUcr /3HCGMZvT1KWVtK34wjtdXdZzQ2tyHCmLPKrXZXyNMtrN/ovIPCf3s3/EZJzunRqj6LgIb0pZfpw4 /YC6Qve1QkvjWqsv+1jMkcq7n; Received: from 97-122-76-186.hlrn.qwest.net ([97.122.76.186]:38894 helo=localhost.localdomain) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oluk5-002smI-Ts; Fri, 21 Oct 2022 10:19:30 -0600 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH v2] Deprecate MI version 1 Date: Fri, 21 Oct 2022 10:19:18 -0600 Message-Id: <20221021161918.1207183-1-tom@tromey.com> X-Mailer: git-send-email 2.34.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.76.186 X-Source-L: No X-Exim-ID: 1oluk5-002smI-Ts X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-76-186.hlrn.qwest.net (localhost.localdomain) [97.122.76.186]:38894 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3028.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_NUMSUBJECT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Oct 2022 16:20:08 -0000 MI version 1 is long since obsolete. Rather than remove it immediately (though I did send a patch for that), instead let's deprecate it in GDB 13 and then remove it for GDB 14. This version of the patch incorporates Simon's warning change, and Luis' recommendation to mention the gdb versions here. --- gdb/NEWS | 2 ++ gdb/interps.c | 10 ++++++++++ 2 files changed, 12 insertions(+) diff --git a/gdb/NEWS b/gdb/NEWS index 8b519a648f7..0642d7637b8 100644 --- a/gdb/NEWS +++ b/gdb/NEWS @@ -3,6 +3,8 @@ *** Changes since GDB 12 +* MI version 1 is deprecated, and will be removed in GDB 14. + * GDB now supports dumping memory tag data for AArch64 MTE. It also supports reading memory tag data for AArch64 MTE from core files generated by the gcore command or the Linux kernel. diff --git a/gdb/interps.c b/gdb/interps.c index a8bd67258e4..56d47906770 100644 --- a/gdb/interps.c +++ b/gdb/interps.c @@ -170,11 +170,16 @@ interp_set (struct interp *interp, bool top_level) if (interpreter_p != interp->name ()) interpreter_p = interp->name (); + bool warn_about_mi1 = false; + /* Run the init proc. */ if (!interp->inited) { interp->init (top_level); interp->inited = true; + + if (streq (interp->name (), "mi1")) + warn_about_mi1 = true; } /* Do this only after the interpreter is initialized. */ @@ -184,6 +189,11 @@ interp_set (struct interp *interp, bool top_level) clear_interpreter_hooks (); interp->resume (); + + if (warn_about_mi1) + warning (_("MI version 1 is deprecated in GDB 13 and " + "will be removed in GDB 14. Please upgrade " + "to a newer version of MI.")); } /* Look up the interpreter for NAME. If no such interpreter exists, -- 2.34.3