From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (woodpecker.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id 865A93858C62 for ; Fri, 4 Nov 2022 00:42:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 865A93858C62 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org Received: by smtp.gentoo.org (Postfix, from userid 559) id CC35B3407AF; Fri, 4 Nov 2022 00:41:07 +0000 (UTC) From: Mike Frysinger To: gdb-patches@sourceware.org Subject: [PATCH] sim: mips: call Unpredictable instead of setting bogus values [PR sim/29276] Date: Fri, 4 Nov 2022 07:41:04 +0700 Message-Id: <20221104004104.20150-1-vapier@gentoo.org> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.1 required=5.0 tests=BAYES_00,GIT_PATCH_0,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: The intention of this code seems to be to indicate that this insn should not be used and produces undefined behavior, so instead of setting registers to bogus values, call Unpredictable. This fixes build warnings due to 32-bit/64-bit type conversions, and outputs a log message for users at runtime instead of silent corruption. Bug: https://sourceware.org/PR29276 --- sim/mips/mips.igen | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sim/mips/mips.igen b/sim/mips/mips.igen index dfad42276155..0746a52d5ab1 100644 --- a/sim/mips/mips.igen +++ b/sim/mips/mips.igen @@ -1450,7 +1450,7 @@ else if ((fs & 0x1) == 0) GPR[rt] = SET64HI (FGR[fs+1]) | FGR[fs]; else - GPR[rt] = SET64HI (0xDEADC0DE) | 0xBAD0BAD0; + Unpredictable (); TRACE_ALU_RESULT (GPR[rt]); } @@ -5782,7 +5782,7 @@ else if ((FS & 0x1) == 0) v = SET64HI (FGR[FS+1]) | FGR[FS]; else - v = SET64HI (0xDEADC0DE) | 0xBAD0BAD0; + Unpredictable (); PENDING_FILL (RT, v); TRACE_ALU_RESULT (v); } -- 2.38.1