From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lndn.lancelotsix.com (lndn.lancelotsix.com [51.195.220.111]) by sourceware.org (Postfix) with ESMTPS id 9CD8D385840B for ; Fri, 4 Nov 2022 12:20:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9CD8D385840B Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=lancelotsix.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=lancelotsix.com Received: from ubuntu.lan (unknown [IPv6:2a02:390:9086::635]) by lndn.lancelotsix.com (Postfix) with ESMTPSA id 88BFD80013; Fri, 4 Nov 2022 12:20:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=lancelotsix.com; s=2021; t=1667564442; bh=+TjBzf/pzmEfJH2ODiWy46rw9kvV+d0jLnfjqA8+8xg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=meZLaGkQrOmvmP7lUpM+3VVcR+eA80rERM4ECJryNlvNtK4lp/giv51HJsv5+f4L0 jcpSzRqDAspXLCtqEbFsYfkLQsUBIoagmSqFg0IgoOkhVqMeU5V6PlBzRiSPaEixtI FPtG5jpCnSp0p5VpD+E9VYApm88NkBnyRgf1GB9fNO8eajC69qNlk+wNnHaXq5akMu eU5SE0FspeOdOHAOsTVDLDlyY/t4pn6daZyGjF0WUpVka1p8/vKEWloR0e3Tjj01An 4AabjHLwoyGtw8p1PbPpoDFiMlG6iPMU3qJigeS/LV23YAseMEAyBUfvyUi/tk27Ve S5wr14Ey9tsfw== Date: Fri, 4 Nov 2022 12:20:10 +0000 From: Lancelot SIX To: Andrew Burgess Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 01/12] gdb: int to bool conversion for normal_stop Message-ID: <20221104122010.tgwbzndjdrrufi7i@ubuntu.lan> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.11 (lndn.lancelotsix.com [0.0.0.0]); Fri, 04 Nov 2022 12:20:42 +0000 (UTC) X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Andrew, I believe there is one more callsite which can be updated in infrun.c:fetch_inferior_event: diff --git a/gdb/infrun.c b/gdb/infrun.c index 3660272ef11..666c1c17f15 100644 --- a/gdb/infrun.c +++ b/gdb/infrun.c @@ -4248,7 +4248,7 @@ fetch_inferior_event () else { bool should_notify_stop = true; - int proceeded = 0; + bool proceeded = false; stop_all_threads_if_all_stop_mode (); Otherwise, this looks good to me. Best, Lancelot. On Fri, Oct 21, 2022 at 09:43:37AM +0100, Andrew Burgess via Gdb-patches wrote: > Change the return type of normal_stop (infrun.c) from int to bool. > Update callers. > > There should be no user visible changes after this commit. > --- > gdb/infcmd.c | 2 +- > gdb/infrun.c | 6 +++--- > gdb/infrun.h | 2 +- > 3 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/gdb/infcmd.c b/gdb/infcmd.c > index d729732c81c..6af11ac0cb6 100644 > --- a/gdb/infcmd.c > +++ b/gdb/infcmd.c > @@ -873,7 +873,7 @@ step_1 (int skip_subroutines, int single_inst, const char *count_string) > proceed ((CORE_ADDR) -1, GDB_SIGNAL_DEFAULT); > else > { > - int proceeded; > + bool proceeded; > > /* Stepped into an inline frame. Pretend that we've > stopped. */ > diff --git a/gdb/infrun.c b/gdb/infrun.c > index cdfe02393f5..39840ef32c8 100644 > --- a/gdb/infrun.c > +++ b/gdb/infrun.c > @@ -8614,7 +8614,7 @@ stop_context::changed () const > > /* See infrun.h. */ > > -int > +bool > normal_stop (void) > { > struct target_waitstatus last; > @@ -8774,7 +8774,7 @@ normal_stop (void) > the observers would print a stop for the wrong > thread/inferior. */ > if (saved_context.changed ()) > - return 1; > + return true; > > /* Notify observers about the stop. This is where the interpreters > print the stop event. */ > @@ -8796,7 +8796,7 @@ normal_stop (void) > breakpoint_auto_delete (inferior_thread ()->control.stop_bpstat); > } > > - return 0; > + return false; > } > > int > diff --git a/gdb/infrun.h b/gdb/infrun.h > index c711b9b21cc..11a18583e68 100644 > --- a/gdb/infrun.h > +++ b/gdb/infrun.h > @@ -149,7 +149,7 @@ extern process_stratum_target *user_visible_resume_target (ptid_t resume_ptid); > appropriate messages, remove breakpoints, give terminal our modes, > and run the stop hook. Returns true if the stop hook proceeded the > target, false otherwise. */ > -extern int normal_stop (void); > +extern bool normal_stop (void); > > /* Return the cached copy of the last target/ptid/waitstatus returned > by target_wait(). The data is actually cached by handle_inferior_event(), > -- > 2.25.4 >