From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org
Subject: [PATCH 2/9] [gdb/testsuite] Fix gdb.base/info_sources_2.exp for remote target
Date: Mon, 7 Nov 2022 17:13:26 +0100 [thread overview]
Message-ID: <20221107161333.16999-3-tdevries@suse.de> (raw)
In-Reply-To: <20221107161333.16999-1-tdevries@suse.de>
With test-case gdb.base/info_sources_2.exp and target board
remote-gdbserver-on-localhost (using REMOTE_TARGET_USERNAME) we run into some
failures.
Fix these by adding the missing gdb_load_shlib.
Tested on x86_64-linux.
---
gdb/testsuite/gdb.base/info_sources_2.exp | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/gdb/testsuite/gdb.base/info_sources_2.exp b/gdb/testsuite/gdb.base/info_sources_2.exp
index f9246b8fa96..9fe3d479018 100644
--- a/gdb/testsuite/gdb.base/info_sources_2.exp
+++ b/gdb/testsuite/gdb.base/info_sources_2.exp
@@ -20,6 +20,8 @@ if { [skip_shlib_tests] } {
return 0
}
+set is_remote_target [is_remote target]
+
standard_testfile -test.c -lib.c
set solib_name [standard_output_file ${testfile}-lib.so]
@@ -37,6 +39,8 @@ if {[gdb_compile ${srcdir}/${subdir}/${srcfile} ${binfile} executable \
clean_restart ${binfile}
+set solib_name [gdb_load_shlib $solib_name]
+
if ![runto foo] {
untested "failed to run to function foo"
return -1
@@ -55,6 +59,7 @@ if ![runto foo] {
# file is NOT listed for the given object file.
proc run_info_sources { extra_args args } {
global gdb_prompt srcdir subdir
+ global is_remote_target
with_test_prefix "args: ${extra_args}" {
@@ -76,6 +81,9 @@ proc run_info_sources { extra_args args } {
-re "^(\[^\r\n\]+):\r\n" {
set objfile_name $expect_out(1,string)
+ if { $is_remote_target } {
+ set objfile_name [file tail $objfile_name]
+ }
exp_continue
}
@@ -129,6 +137,10 @@ proc run_info_sources { extra_args args } {
# Figure out the path for SOURCEFILE that we're looking for.
set sourcepath [file normalize ${srcdir}/${subdir}/${sourcefile}]
+ if { $is_remote_target } {
+ set objfile [file tail $objfile]
+ }
+
# Make sure we handle the case where there are no source files
# associated with a particular objfile.
set source_list {}
--
2.35.3
next prev parent reply other threads:[~2022-11-07 16:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-07 16:13 [PATCH 0/9] [gdb/testsuite] Fix remote target test fails Tom de Vries
2022-11-07 16:13 ` [PATCH 1/9] [gdb/testsuite] Fix gdb.base/foll-exec.exp for remote target Tom de Vries
2022-11-07 16:13 ` Tom de Vries [this message]
2022-11-07 16:13 ` [PATCH 3/9] [gdb/testsuite] Add REMOTE_TARGET_USERNAME in remote-gdbserver-on-localhost.exp Tom de Vries
2022-11-08 9:18 ` Tom de Vries
2022-11-09 20:49 ` Tom de Vries
2022-11-15 14:31 ` Tom de Vries
2022-11-07 16:13 ` [PATCH 4/9] [gdb/testsuite] Fix gdb.base/print-file-var.exp for remote target Tom de Vries
2022-11-07 16:13 ` [PATCH 5/9] [gdb/testsuite] Fix gdb.base/infcall-exec.exp " Tom de Vries
2022-11-07 16:13 ` [PATCH 6/9] [gdb/testsuite] Fix gdb.base/solib-vanish.exp " Tom de Vries
2022-11-07 16:13 ` [PATCH 7/9] [gdb/testsuite] Fix gdb.base/info-shared.exp " Tom de Vries
2022-11-07 16:13 ` [PATCH 8/9] [gdb/testsuite] Fix gdb.base/jit-reader-exec.exp " Tom de Vries
2022-11-07 16:13 ` [PATCH 9/9] [gdb/testsuite] Fix gdb.base/jit-elf-so.exp " Tom de Vries
2022-11-15 14:30 ` [PATCH 0/9] [gdb/testsuite] Fix remote target test fails Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221107161333.16999-3-tdevries@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).