From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (smtp.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id A56D13857C43 for ; Wed, 9 Nov 2022 15:34:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A56D13857C43 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org Received: by smtp.gentoo.org (Postfix, from userid 559) id 25258340DB0; Wed, 9 Nov 2022 15:34:56 +0000 (UTC) From: Mike Frysinger To: gdb-patches@sourceware.org Subject: [PATCH] sim: ppc: add missing parens with e500 macro Date: Wed, 9 Nov 2022 22:34:53 +0700 Message-Id: <20221109153453.7544-1-vapier@gentoo.org> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00,GIT_PATCH_0,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This macro expansion was missing a set of outer-most parenthesis which some compilers would complain about depending on how the macro is used. This is just standard good macro hygiene too. --- sim/ppc/e500_expression.h | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/sim/ppc/e500_expression.h b/sim/ppc/e500_expression.h index 1a27bb189e85..86d033ae66f3 100644 --- a/sim/ppc/e500_expression.h +++ b/sim/ppc/e500_expression.h @@ -68,22 +68,22 @@ /* bit manipulation macros needed for e500 SPE */ #define EV_BITREVERSE16(x) \ - (((x) & 0x0001) << 15) \ - | (((x) & 0x0002) << 13) \ - | (((x) & 0x0004) << 11) \ - | (((x) & 0x0008) << 9) \ - | (((x) & 0x0010) << 7) \ - | (((x) & 0x0020) << 5) \ - | (((x) & 0x0040) << 3) \ - | (((x) & 0x0080) << 1) \ - | (((x) & 0x0100) >> 1) \ - | (((x) & 0x0200) >> 3) \ - | (((x) & 0x0400) >> 5) \ - | (((x) & 0x0800) >> 7) \ - | (((x) & 0x1000) >> 9) \ - | (((x) & 0x2000) >> 11) \ - | (((x) & 0x4000) >> 13) \ - | (((x) & 0x8000) >> 15) + ((((x) & 0x0001) << 15) \ + | (((x) & 0x0002) << 13) \ + | (((x) & 0x0004) << 11) \ + | (((x) & 0x0008) << 9) \ + | (((x) & 0x0010) << 7) \ + | (((x) & 0x0020) << 5) \ + | (((x) & 0x0040) << 3) \ + | (((x) & 0x0080) << 1) \ + | (((x) & 0x0100) >> 1) \ + | (((x) & 0x0200) >> 3) \ + | (((x) & 0x0400) >> 5) \ + | (((x) & 0x0800) >> 7) \ + | (((x) & 0x1000) >> 9) \ + | (((x) & 0x2000) >> 11) \ + | (((x) & 0x4000) >> 13) \ + | (((x) & 0x8000) >> 15)) /* saturation helpers */ #define EV_MUL16_SSF(a,b) ((int64_t)((int32_t)(int16_t)(a) * (int32_t)(int16_t)(b)) << 1) -- 2.38.1