public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Dimitar Dimitrov <dimitar@dinux.eu>
To: gdb-patches@sourceware.org
Cc: Dimitar Dimitrov <dimitar@dinux.eu>
Subject: [PATCH] sim: pru: Fix behaviour when loop count is zero
Date: Sat, 12 Nov 2022 11:13:38 +0200	[thread overview]
Message-ID: <20221112091338.558105-1-dimitar@dinux.eu> (raw)

If the counter for LOOP instruction is provided by a register with
value zero, then the instruction must cause a PC jump directly to the
loop end.  But in that particular case simulator must not initialize
its internal loop variables, because loop body will not be executed.
Instead, simulator must obtain the loop's end address directly from
the LOOP instruction.

Ok for trunk?

Signed-off-by: Dimitar Dimitrov <dimitar@dinux.eu>
---
 sim/pru/pru.isa               |  4 ++--
 sim/testsuite/pru/loop-zero.s | 41 +++++++++++++++++++++++++++++++++++
 2 files changed, 43 insertions(+), 2 deletions(-)
 create mode 100644 sim/testsuite/pru/loop-zero.s

diff --git a/sim/pru/pru.isa b/sim/pru/pru.isa
index b7d8b4af8b9..be8cdfd27fb 100644
--- a/sim/pru/pru.isa
+++ b/sim/pru/pru.isa
@@ -222,7 +222,7 @@ INSTRUCTION (loop,
 	     OP2 = (IO ? IMM8 + 1 : RS2_w0);
 	     if (OP2 == 0)
 	      {
-		PC = LOOPEND;
+		PC = PC + LOOP_JMPOFFS;
 	      }
 	     else
 	      {
@@ -237,7 +237,7 @@ INSTRUCTION (iloop,
 	     OP2 = (IO ? IMM8 + 1 : RS2_w0);
 	     if (OP2 == 0)
 	      {
-		PC = LOOPEND;
+		PC = PC + LOOP_JMPOFFS;
 	      }
 	     else
 	      {
diff --git a/sim/testsuite/pru/loop-zero.s b/sim/testsuite/pru/loop-zero.s
new file mode 100644
index 00000000000..65330f27beb
--- /dev/null
+++ b/sim/testsuite/pru/loop-zero.s
@@ -0,0 +1,41 @@
+# Check that loop insn works if register value is zero.
+# mach: pru
+
+# Copyright (C) 2022 Free Software Foundation, Inc.
+# Contributed by Dimitar Dimitrov <dimitar@dinux.eu>
+#
+# This file is part of the GNU simulators.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+.include "testutils.inc"
+
+	start
+
+	ldi r25, 0
+	ldi r27, 0
+	ldi r28, 10
+
+	loop 1f, r25
+	add r27, r27, 1
+	add r28, r28, 1
+1:
+
+	qbne F, r25, 0
+	qbne F, r27, 0
+	qbne F, r28, 10
+
+	pass
+
+F:	fail
-- 
2.38.1


             reply	other threads:[~2022-11-12  9:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-12  9:13 Dimitar Dimitrov [this message]
2022-11-12 11:51 ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221112091338.558105-1-dimitar@dinux.eu \
    --to=dimitar@dinux.eu \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).