From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from barracuda.ebox.ca (barracuda.ebox.ca [96.127.255.19]) by sourceware.org (Postfix) with ESMTPS id E3387385220C for ; Thu, 17 Nov 2022 19:42:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E3387385220C Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=efficios.com X-ASG-Debug-ID: 1668714162-0c856e02a015b8c0001-fS2M51 Received: from smtp.ebox.ca (smtp.ebox.ca [96.127.255.82]) by barracuda.ebox.ca with ESMTP id ktZOMpPnpg4amiU6 (version=TLSv1 cipher=AES128-SHA bits=128 verify=NO); Thu, 17 Nov 2022 14:42:42 -0500 (EST) X-Barracuda-Envelope-From: simon.marchi@efficios.com X-Barracuda-RBL-Trusted-Forwarder: 96.127.255.82 Received: from epycamd.internal.efficios.com (192-222-180-24.qc.cable.ebox.net [192.222.180.24]) by smtp.ebox.ca (Postfix) with ESMTP id 23920441B21; Thu, 17 Nov 2022 14:42:42 -0500 (EST) From: Simon Marchi X-Barracuda-RBL-IP: 192.222.180.24 X-Barracuda-Effective-Source-IP: 192-222-180-24.qc.cable.ebox.net[192.222.180.24] X-Barracuda-Apparent-Source-IP: 192.222.180.24 To: gdb-patches@sourceware.org Cc: Simon Marchi Subject: [PATCH 0/8] Fix some commit_resumed_state assertion failures (PR 28275) Date: Thu, 17 Nov 2022 14:42:33 -0500 X-ASG-Orig-Subj: [PATCH 0/8] Fix some commit_resumed_state assertion failures (PR 28275) Message-Id: <20221117194241.1776125-1-simon.marchi@efficios.com> X-Mailer: git-send-email 2.37.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Barracuda-Connect: smtp.ebox.ca[96.127.255.82] X-Barracuda-Start-Time: 1668714162 X-Barracuda-Encrypted: AES128-SHA X-Barracuda-URL: https://96.127.255.19:443/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at ebox.ca X-Barracuda-Scan-Msg-Size: 1679 X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using global scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=5.0 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.3.102207 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Spam-Status: No, score=-3492.4 required=5.0 tests=BAYES_00,KAM_DMARC_NONE,KAM_DMARC_STATUS,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_SOFTFAIL,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This series fixes some assertion failures related to the commit_resumed_state flag being set while target_{wait,kill,stop} is called. Patch 3 comes from Andrew Burgess, it fixes the case where GDB detaches an inferior while quitting, while the inferior is doing a step-over. Patch 8 fixes the main issue reported by PR 28275. The other patches are cleanups or fixes for other problems found while working on this. Andrew Burgess (2): gdb/testsuite: refactor gdb.threads/detach-step-over.exp gdb: fix assert when quitting GDB while a thread is stepping Simon Marchi (6): gdb/testsuite: remove global declarations in gdb.threads/detach-step-over.exp gdbserver/linux: take condition out of callback in find_lwp_pid gdbserver/linux-x86: make is_64bit_tdesc accept thread as a parameter gdbserver: use current_process in ps_getpid gdbserver: switch to right process in find_one_thread gdb: disable commit resumed in target_kill gdb/target.c | 13 +- .../gdb.base/run-control-while-bg-execution.c | 33 ++ .../run-control-while-bg-execution.exp | 118 +++++++ .../gdb.threads/detach-step-over.exp | 322 +++++++++++------- gdbserver/linux-low.cc | 4 +- gdbserver/linux-x86-low.cc | 27 +- gdbserver/proc-service.cc | 2 +- gdbserver/thread-db.cc | 29 +- 8 files changed, 400 insertions(+), 148 deletions(-) create mode 100644 gdb/testsuite/gdb.base/run-control-while-bg-execution.c create mode 100644 gdb/testsuite/gdb.base/run-control-while-bg-execution.exp -- 2.37.3