From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 0A6BA384F481 for ; Thu, 24 Nov 2022 03:03:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0A6BA384F481 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669258994; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=q/wAVtoiLjWeSmE1OmXc9fBmwBPFOwFCM2os/6/UJRI=; b=PK2loOaAuVtgKIRIg9w65FON2IjaL+C20GPuDPQTbuzzGBB/T0ApUw2cH+97AdqlVeWUZO dhObRD7y8ximFcoA+t3tR02PjYAf9Iy3ATN/zb7400KljkN9PIAhih95da67bxpwBJxSkZ w0JImqFva6XqBQjVUOgInL6hkO6sfT8= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-649-qnyQmE86MvmHIisxznuirA-1; Wed, 23 Nov 2022 22:03:07 -0500 X-MC-Unique: qnyQmE86MvmHIisxznuirA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 02BF68339C1; Thu, 24 Nov 2022 03:03:07 +0000 (UTC) Received: from f35-zws-nvidia (unknown [10.2.17.12]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2F0B94EA4E; Thu, 24 Nov 2022 03:03:06 +0000 (UTC) Date: Wed, 23 Nov 2022 20:03:02 -0700 From: Kevin Buettner To: Simon Marchi via Gdb-patches Cc: Simon Marchi Subject: Re: [PATCH 00/14] Break up gdb.base/break.exp in multiple procs Message-ID: <20221123200302.34d78f05@f35-zws-nvidia> In-Reply-To: <20221123183959.2476477-1-simon.marchi@polymtl.ca> References: <20221123183959.2476477-1-simon.marchi@polymtl.ca> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Simon, On Wed, 23 Nov 2022 13:39:45 -0500 Simon Marchi via Gdb-patches wrote: > The test gdb.base/break.exp feels like a big house of cards that will > crumble the second you touch it. It is very long and it's really not > clear which test depends on the state left by which previous test. This > series aims at making it more manageable by breaking it up into many > procs, each starting with a fresh GDB. So you can be confident that the > tests in a proc only depends on the state of GDB resulting of other > tests in the same proc. > > Simon Marchi (14): > gdb/testsuite/gdb.base/break.exp: split test_break_commands_clear > gdb/testsuite/gdb.base/break.exp: split > test_break_file_line_convenience_var > gdb/testsuite/gdb.base/break.exp: split test_rbreak_shlib > gdb/testsuite/gdb.base/break.exp: split test_break_optimized_prologue > gdb/testsuite/gdb.base/break.exp: use proc_with_prefix for > test_next_with_recursion > gdb/testsuite/gdb.base/break.exp: split test_finish_arguments > gdb/testsuite/gdb.base/break.exp: split test_break_user_call > gdb/testsuite/gdb.base/break.exp: split > test_break_line_convenience_var > gdb/testsuite/gdb.base/break.exp: split test_break_silent_and_more > gdb/testsuite/gdb.base/break.exp: split test_break_default > gdb/testsuite/gdb.base/break.exp: split test_break_nonexistent_line > gdb/testsuite/gdb.base/break.exp: split test_no_break_on_catchpoint > gdb/testsuite/gdb.base/break.exp: split test_tbreak > gdb/testsuite/gdb.base/break.exp: split test_break > > gdb/testsuite/gdb.base/break.exp | 1191 +++++++++++++++--------------- > 1 file changed, 615 insertions(+), 576 deletions(-) Thanks for doing this! I looked at each patch in this series. LGTM. Kevin