From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x232.google.com (mail-oi1-x232.google.com [IPv6:2607:f8b0:4864:20::232]) by sourceware.org (Postfix) with ESMTPS id 3F6AD38451B3 for ; Sat, 26 Nov 2022 02:05:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3F6AD38451B3 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-oi1-x232.google.com with SMTP id n186so6096734oih.7 for ; Fri, 25 Nov 2022 18:05:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=AsprGWoNf7eKHygJV85RKVoDXmOCFsW3sIHXe1eg9Pw=; b=d3VibRs2C0BSRkaqO0tCrjDl2+UvQ3FCTp8PVxpWSFjZfmxo7FIlqQsoDdWFk2aatW 2/75c/FKwUT2p1UxQgVRg19K44MYZ+v/NNOlSguDGORBImwBw7/pIoh1E6eGdEqs4Kfp KHrx4UfesbeE/CEPw6bbtJ26C+r6rcwFzHTs1pFV6JVVOjlV960JG+DfAJ9WXofgCvzc oYs/lFUbK6/YxXIiU9Mx82t6CQfKeCXE42RMzsBOUp8HyNnZCNOXznT6nQyTEOSCvYVw n0qVSqAZ7DeIAXkAh78MIy/OAoqpBT7csZjrI6mL1V9sVIxlT5G8q0TrvzWYoYSJJ9fK ugXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AsprGWoNf7eKHygJV85RKVoDXmOCFsW3sIHXe1eg9Pw=; b=h6AIQdjsTaJD5roicaDDY7eTAzfIqoZryEKKXHRNG/jEecweoM3pyqvxHG/eb5UjDS PSnIpcw6V43T3PVKmLdvAv0tPXSSBiIXkKenDZDnj8MXIR6UQ5yR0sGP/H8GLsurzV1J xQf4foHjg+vg86MyTnkOP6g2mcVyoaAklpachTqZnrF0o/cKkedVYR3AVsw1oWAT1E3C Mhe0Eahz9j+k6Dgj+kr7BueEU2SQZPWGbVzLRmxxX2xwcqzPAx7fizwZ8+s77PiKqsKd PDKeXYszHDhFyxdwCiaD217P8jnbPTyBJpE0S7pOPcvQn8PQfET/w651V92+PIVPug6n AKEQ== X-Gm-Message-State: ANoB5pnT8fKBTxBHKUSKnWh+lIwXhx0kuzH+8wPJfsnmpt99kohWAW2N aVzOOV6yIEfcyWViERVFEnWbpQPf51iApQ== X-Google-Smtp-Source: AA0mqf6tdpMlBXlFaztJhw2EgFyONjVPnGrMIs8aTDydbBSwkn22WI0hB6MHACmXEnb7yJmJATqDcw== X-Received: by 2002:a05:6808:3096:b0:355:ebd:8b3a with SMTP id bl22-20020a056808309600b003550ebd8b3amr19293408oib.117.1669428315692; Fri, 25 Nov 2022 18:05:15 -0800 (PST) Received: from localhost ([2804:14d:7e39:8470:41ee:c7fc:c991:eee6]) by smtp.gmail.com with ESMTPSA id k17-20020a4ae291000000b004805b00b2cdsm2142450oot.28.2022.11.25.18.05.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Nov 2022 18:05:15 -0800 (PST) From: Thiago Jung Bauermann To: gdb-patches@sourceware.org Cc: Luis Machado , Thiago Jung Bauermann Subject: [PATCH v2 1/6] gdbserver: Add asserts in register_size and register_data functions Date: Sat, 26 Nov 2022 02:04:47 +0000 Message-Id: <20221126020452.1686509-2-thiago.bauermann@linaro.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221126020452.1686509-1-thiago.bauermann@linaro.org> References: <20221126020452.1686509-1-thiago.bauermann@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-10.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: These helped me during development, catching bugs closer to when they actually happened. --- gdbserver/regcache.cc | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/gdbserver/regcache.cc b/gdbserver/regcache.cc index 5cbcea978a05..14236069f712 100644 --- a/gdbserver/regcache.cc +++ b/gdbserver/regcache.cc @@ -286,6 +286,8 @@ register_cache_size (const struct target_desc *tdesc) int register_size (const struct target_desc *tdesc, int n) { + gdb_assert (n >= 0 && n < tdesc->reg_defs.size ()); + return find_register_by_number (tdesc, n).size / 8; } @@ -300,6 +302,8 @@ regcache_register_size (const struct regcache *regcache, int n) static unsigned char * register_data (const struct regcache *regcache, int n) { + gdb_assert(n >= 0 && n < regcache->tdesc->reg_defs.size()); + return (regcache->registers + find_register_by_number (regcache->tdesc, n).offset / 8); }