From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by sourceware.org (Postfix) with ESMTPS id CC93B3858412 for ; Wed, 30 Nov 2022 10:37:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CC93B3858412 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E77311FD70 for ; Wed, 30 Nov 2022 10:37:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1669804667; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=q+Bu7vZrP02ivwEtnFiRy1srKi/ZBdpSTeYDsjOXvg8=; b=1snhyYsHLiCiRqV9s1hRe+7C1hnSCC+WqsqLihtfNUheORj3Qfm7WT6wkC5HsmB2mZImc7 jY/hA5B4rrzh6o1dXozvlVYGIAKGmE0KFlebNsNHHcmmNvbOLKDFbOCmX8PwiYMgkUGAc1 AawzLmBiETFLOolt581nJtipyVkPRRQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1669804667; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=q+Bu7vZrP02ivwEtnFiRy1srKi/ZBdpSTeYDsjOXvg8=; b=6Mm3Jjqs/H0G1QOTeuXGK+sllcJVmGemvWb+Ia/dLtRrGNIRWvtMeJelvE1vQ2vv9aDVax Fjk0Zi+gZefIAPBQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id CEB6E1331F for ; Wed, 30 Nov 2022 10:37:47 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id nyBDMXsyh2MmBQAAMHmgww (envelope-from ) for ; Wed, 30 Nov 2022 10:37:47 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [pushed] [gdb] Improve printing of float formats Date: Wed, 30 Nov 2022 11:37:47 +0100 Message-Id: <20221130103747.24467-1-tdevries@suse.de> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Currently, on x86_64, a little endian target, I get: ... $ gdb -q -batch -ex "maint print architecture" | grep " = floatformat" gdbarch_dump: bfloat16_format = floatformat_bfloat16_big gdbarch_dump: double_format = floatformat_ieee_double_big gdbarch_dump: float_format = floatformat_ieee_single_big gdbarch_dump: half_format = floatformat_ieee_half_big gdbarch_dump: long_double_format = floatformat_i387_ext ... which suggests big endian. This is due to this bit of code in pformat: ... /* Just print out one of them - this is only for diagnostics. */ return format[0]->name; ... Fix this by using gdbarch_byte_order to pick the appropriate index, such that we have the more accurate: ... gdbarch_dump: bfloat16_format = floatformat_bfloat16_little gdbarch_dump: half_format = floatformat_ieee_half_little gdbarch_dump: float_format = floatformat_ieee_single_little gdbarch_dump: double_format = floatformat_ieee_double_little gdbarch_dump: long_double_format = floatformat_i387_ext ... Tested on x86_64-linux. --- gdb/arch-utils.c | 8 ++++---- gdb/gdbarch-components.py | 10 +++++----- gdb/gdbarch.c | 10 +++++----- 3 files changed, 14 insertions(+), 14 deletions(-) diff --git a/gdb/arch-utils.c b/gdb/arch-utils.c index 7b84daf046e..60ffdc5e16a 100644 --- a/gdb/arch-utils.c +++ b/gdb/arch-utils.c @@ -1104,13 +1104,13 @@ show_gdbarch_debug (struct ui_file *file, int from_tty, } static const char * -pformat (const struct floatformat **format) +pformat (struct gdbarch *gdbarch, const struct floatformat **format) { if (format == NULL) return "(null)"; - else - /* Just print out one of them - this is only for diagnostics. */ - return format[0]->name; + + int format_index = gdbarch_byte_order (gdbarch) == BFD_ENDIAN_LITTLE ? 1 : 0; + return format[format_index]->name; } static const char * diff --git a/gdb/gdbarch-components.py b/gdb/gdbarch-components.py index 9b688998a7b..e7230949aad 100644 --- a/gdb/gdbarch-components.py +++ b/gdb/gdbarch-components.py @@ -201,7 +201,7 @@ Value( name="bfloat16_format", postdefault="floatformats_bfloat16", invalid=True, - printer="pformat (gdbarch->bfloat16_format)", + printer="pformat (gdbarch, gdbarch->bfloat16_format)", ) Value( @@ -216,7 +216,7 @@ Value( name="half_format", postdefault="floatformats_ieee_half", invalid=True, - printer="pformat (gdbarch->half_format)", + printer="pformat (gdbarch, gdbarch->half_format)", ) Value( @@ -231,7 +231,7 @@ Value( name="float_format", postdefault="floatformats_ieee_single", invalid=True, - printer="pformat (gdbarch->float_format)", + printer="pformat (gdbarch, gdbarch->float_format)", ) Value( @@ -246,7 +246,7 @@ Value( name="double_format", postdefault="floatformats_ieee_double", invalid=True, - printer="pformat (gdbarch->double_format)", + printer="pformat (gdbarch, gdbarch->double_format)", ) Value( @@ -261,7 +261,7 @@ Value( name="long_double_format", postdefault="floatformats_ieee_double", invalid=True, - printer="pformat (gdbarch->long_double_format)", + printer="pformat (gdbarch, gdbarch->long_double_format)", ) Value( diff --git a/gdb/gdbarch.c b/gdb/gdbarch.c index 3227e945880..ddb8dec1c72 100644 --- a/gdb/gdbarch.c +++ b/gdb/gdbarch.c @@ -565,31 +565,31 @@ gdbarch_dump (struct gdbarch *gdbarch, struct ui_file *file) plongest (gdbarch->bfloat16_bit)); gdb_printf (file, "gdbarch_dump: bfloat16_format = %s\n", - pformat (gdbarch->bfloat16_format)); + pformat (gdbarch, gdbarch->bfloat16_format)); gdb_printf (file, "gdbarch_dump: half_bit = %s\n", plongest (gdbarch->half_bit)); gdb_printf (file, "gdbarch_dump: half_format = %s\n", - pformat (gdbarch->half_format)); + pformat (gdbarch, gdbarch->half_format)); gdb_printf (file, "gdbarch_dump: float_bit = %s\n", plongest (gdbarch->float_bit)); gdb_printf (file, "gdbarch_dump: float_format = %s\n", - pformat (gdbarch->float_format)); + pformat (gdbarch, gdbarch->float_format)); gdb_printf (file, "gdbarch_dump: double_bit = %s\n", plongest (gdbarch->double_bit)); gdb_printf (file, "gdbarch_dump: double_format = %s\n", - pformat (gdbarch->double_format)); + pformat (gdbarch, gdbarch->double_format)); gdb_printf (file, "gdbarch_dump: long_double_bit = %s\n", plongest (gdbarch->long_double_bit)); gdb_printf (file, "gdbarch_dump: long_double_format = %s\n", - pformat (gdbarch->long_double_format)); + pformat (gdbarch, gdbarch->long_double_format)); gdb_printf (file, "gdbarch_dump: wchar_bit = %s\n", plongest (gdbarch->wchar_bit)); base-commit: 6bd454ca033dcb2e178721eb004d0c5f24415c4c -- 2.35.3