From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 107E03858288 for ; Wed, 30 Nov 2022 14:58:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 107E03858288 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 3D3C41F74C; Wed, 30 Nov 2022 14:58:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1669820311; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=g19on0XD/RBU8hrIICiUysZpBSyeGQ2wkT8d5Q/jmuY=; b=wv2LQfcE0VFntQhAApN7LVUoLrv6rSjTyS2+obWFJef+j3nSZyiVkH0e3Km/Il4nUnNFLR d+fZ77XT7xk0xK8/JwZMlljefohFlgHOsOgvLNVUq3MDaoiVJ7wwEEWfwob5MhziWF4rKd dXfWhDEmJMy7Mga/9VxVIMKpWTWo65M= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1669820311; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=g19on0XD/RBU8hrIICiUysZpBSyeGQ2wkT8d5Q/jmuY=; b=4M4opp+bX6uIxMIRSCOYooWpbwhieiQseDQotW5yn7QycXy2bUmXoKd5f70N7mKACET8V1 uqKg+dirBEeAM6BQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 25F0D1331F; Wed, 30 Nov 2022 14:58:31 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id qc0qCJdvh2MXEQAAMHmgww (envelope-from ); Wed, 30 Nov 2022 14:58:31 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Cc: Simon Marchi Subject: [PATCH] [gdb/testsuite] Wait longer for core generation Date: Wed, 30 Nov 2022 15:58:30 +0100 Message-Id: <20221130145830.1535-1-tdevries@suse.de> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: When I run the gdb testsuite on a powerpc64le-linux system with (slow) nfs file system, I run into timeouts due to core generation, like for instance: ... (gdb) gcore $outputs/gdb.ada/task_switch_in_core/crash.gcore^M FAIL: gdb.ada/task_switch_in_core.exp: save a corefile (timeout) ... Fix this by using with_timeout_factor 3 in gdb_gcore_cmd. Tested on powerpc64le-linux. --- gdb/testsuite/lib/gdb.exp | 20 +++++++++++++------- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp index 23e3cc0c2d4..f41fc1375aa 100644 --- a/gdb/testsuite/lib/gdb.exp +++ b/gdb/testsuite/lib/gdb.exp @@ -5730,13 +5730,19 @@ proc gdb_gcore_cmd {core test} { global gdb_prompt set result 0 - gdb_test_multiple "gcore $core" $test { - -re "Saved corefile .*\[\r\n\]+$gdb_prompt $" { - pass $test - set result 1 - } - -re "(?:Can't create a corefile|Target does not support core file generation\\.)\[\r\n\]+$gdb_prompt $" { - unsupported $test + + set re_unsupported \ + "(?:Can't create a corefile|Target does not support core file generation\\.)" + + with_timeout_factor 3 { + gdb_test_multiple "gcore $core" $test { + -re -wrap "Saved corefile .*" { + pass $test + set result 1 + } + -re -wrap $re_unsupported { + unsupported $test + } } } base-commit: 016c606c66ce4b98c220130b9046545b04254a4a -- 2.35.3