From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 952703858D35 for ; Thu, 1 Dec 2022 16:27:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 952703858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669912069; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YwuFH34aNbitwD3JjW/CCjZOgFhbGpqykbm2bvimPV8=; b=Kwsl1Omp2l5FREMMCKAgvYdLfWPgnIyvpf6CcFgHluFy9w1ZRcxcYHARIyVKGIL4lCkF0h UAlWT5vWTuMSq+k2Hwv5ejf+h6rGjFP24kL3CnYdoNfkJy29+Wv2ioY+9JeJ2nNbg9SZck THLLN9vSyco/dK3RU/Hx8W6z285G/4E= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-587-2dcxMOqEMPmMk5NEoVhNYw-1; Thu, 01 Dec 2022 11:27:46 -0500 X-MC-Unique: 2dcxMOqEMPmMk5NEoVhNYw-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9C0191C004EB; Thu, 1 Dec 2022 16:27:46 +0000 (UTC) Received: from f35-zws-nvidia (unknown [10.2.17.12]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3F3584B3FCD; Thu, 1 Dec 2022 16:27:46 +0000 (UTC) Date: Thu, 1 Dec 2022 09:27:42 -0700 From: Kevin Buettner To: Simon Marchi via Gdb-patches Cc: Simon Marchi Subject: Re: [PATCH] gdb/dwarf: add some QUIT macros Message-ID: <20221201092742.70e5e920@f35-zws-nvidia> In-Reply-To: <20221201160144.1045410-1-simon.marchi@efficios.com> References: <20221201160144.1045410-1-simon.marchi@efficios.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, 1 Dec 2022 11:01:44 -0500 Simon Marchi via Gdb-patches wrote: > While testing the fix for PR 29105, I noticed I couldn't ctrl-C my way > out of GDB expanding many symtabs. GDB was busy in a loop in > cooked_index_functions::expand_symtabs_matching. Add a QUIT there. I > also happened to see a spot in > cooked_index_functions::expand_matching_symbols where a QUIT would be > useful too, since we iterate over a potentially big number of index > entries and expand CUs in the loop. Add one there too. LGTM. Kevin