From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id C870B3858C53 for ; Fri, 2 Dec 2022 20:09:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C870B3858C53 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 2B2K9SUs018596 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 2 Dec 2022 15:09:32 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 2B2K9SUs018596 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1670011773; bh=b1gbXIcCFOQvG4/qgNNtYTTZI+/wFEcRFMgz36Jzgig=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UB94Zr/HxuvK40yuR1p7OPsQN9yqDZpr3copKI/ceJ2Y1zICX69vb+RpI9e7JrQ/A Sb3eyY5tldsCQUx0OxyjWrHgoxTTwIhqRvRS6HCHyczkAFHPC8ZVA3J3QQaL3xGtfw 4KOYkhZkdKeAYdjqxc4vIHhFLyKiohiOl5Po24YE= Received: from simark.localdomain (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 0BB231E126; Fri, 2 Dec 2022 15:09:28 -0500 (EST) From: Simon Marchi To: gdb-patches@sourceware.org Cc: Simon Marchi Subject: [PATCH 4/6] gdb/linux-nat: check ptrace return value in linux_nat_get_siginfo Date: Fri, 2 Dec 2022 15:09:23 -0500 Message-Id: <20221202200925.245955-4-simon.marchi@polymtl.ca> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221202200925.245955-1-simon.marchi@polymtl.ca> References: <20221202200925.245955-1-simon.marchi@polymtl.ca> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Fri, 2 Dec 2022 20:09:28 +0000 X-Spam-Status: No, score=-3189.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Not a big deal, but it seems strange to check errno instead of the ptrace return value to know whether it succeeded. Change-Id: If0a6d0280ab0e5ecb077e546af0d6fe489c5b9fd --- gdb/linux-nat.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/gdb/linux-nat.c b/gdb/linux-nat.c index c47b8db9299c..b33fac3d1492 100644 --- a/gdb/linux-nat.c +++ b/gdb/linux-nat.c @@ -4443,11 +4443,7 @@ bool linux_nat_get_siginfo (ptid_t ptid, siginfo_t *siginfo) { int pid = get_ptrace_pid (ptid); - - errno = 0; - ptrace (PTRACE_GETSIGINFO, pid, (PTRACE_TYPE_ARG3) 0, siginfo); - - return errno == 0; + return ptrace (PTRACE_GETSIGINFO, pid, (PTRACE_TYPE_ARG3) 0, siginfo) == 0; } /* See nat/linux-nat.h. */ -- 2.38.1