From: Pedro Alves <pedro@palves.net>
To: gdb-patches@sourceware.org
Subject: [PATCH 1/6] Tweak "Using the running image of ..." output
Date: Sat, 3 Dec 2022 21:13:33 +0000 [thread overview]
Message-ID: <20221203211338.2264994-2-pedro@palves.net> (raw)
In-Reply-To: <20221203211338.2264994-1-pedro@palves.net>
Currently, "info files" and "info program" on a few native targets
show:
(gdb) info files
Symbols from "/home/pedro/gdb/tests/threads".
Native process:
Using the running image of child Thread 0x7ffff7d89740 (LWP 1097968).
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
...
(gdb) info program
Using the running image of child Thread 0x7ffff7d89740 (LWP 1097968).
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Program stopped at 0x555555555278.
...
This patch changes them to:
(gdb) info files
Symbols from "/home/pedro/gdb/tests/threads".
Native process:
Using the running image of child process 1097968.
^^^^^^^^^^^^^^^
...
(gdb) info program
Using the running image of child process 1097968.
^^^^^^^^^^^^^^^
Program stopped at 0x555555555278.
...
... which I think makes a lot more sense in this context. The "info
program" manual entry even says:
"Display information about the status of your program: whether it is
running or not, what process it is, and why it stopped."
^^^^^^^^^^^^^
This change affects ptrace targets, procfs targets, and Windows.
Change-Id: I6aab061ff494a84ba3398cf98fd49efd7a6ec1ca
---
gdb/inf-ptrace.c | 2 +-
gdb/nto-procfs.c | 2 +-
gdb/procfs.c | 2 +-
gdb/windows-nat.c | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/gdb/inf-ptrace.c b/gdb/inf-ptrace.c
index ab669a7acc2..ade07f41ef4 100644
--- a/gdb/inf-ptrace.c
+++ b/gdb/inf-ptrace.c
@@ -522,7 +522,7 @@ inf_ptrace_target::files_info ()
gdb_printf (_("\tUsing the running image of %s %s.\n"),
inf->attach_flag ? "attached" : "child",
- target_pid_to_str (inferior_ptid).c_str ());
+ target_pid_to_str (ptid_t (inf->pid)).c_str ());
}
std::string
diff --git a/gdb/nto-procfs.c b/gdb/nto-procfs.c
index 4a2968ea179..fe9aa8dabfa 100644
--- a/gdb/nto-procfs.c
+++ b/gdb/nto-procfs.c
@@ -658,7 +658,7 @@ nto_procfs_target::files_info ()
gdb_printf ("\tUsing the running image of %s %s via %s.\n",
inf->attach_flag ? "attached" : "child",
- target_pid_to_str (inferior_ptid).c_str (),
+ target_pid_to_str (ptid_t (inf->pid)).c_str (),
(nodestr != NULL) ? nodestr : "local node");
}
diff --git a/gdb/procfs.c b/gdb/procfs.c
index ac3d60ebf1c..ffc26c8fb9e 100644
--- a/gdb/procfs.c
+++ b/gdb/procfs.c
@@ -2533,7 +2533,7 @@ procfs_target::files_info ()
gdb_printf (_("\tUsing the running image of %s %s via /proc.\n"),
inf->attach_flag? "attached": "child",
- target_pid_to_str (inferior_ptid).c_str ());
+ target_pid_to_str (ptid_t (inf->pid)).c_str ());
}
/* Make it die. Wait for it to die. Clean up after it. Note: this
diff --git a/gdb/windows-nat.c b/gdb/windows-nat.c
index b3329cd1a0d..ee4e78bdabf 100644
--- a/gdb/windows-nat.c
+++ b/gdb/windows-nat.c
@@ -2157,7 +2157,7 @@ windows_nat_target::files_info ()
gdb_printf ("\tUsing the running image of %s %s.\n",
inf->attach_flag ? "attached" : "child",
- target_pid_to_str (inferior_ptid).c_str ());
+ target_pid_to_str (ptid_t (inf->pid)).c_str ());
}
/* Modify CreateProcess parameters for use of a new separate console.
--
2.36.0
next prev parent reply other threads:[~2022-12-03 21:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-03 21:13 [PATCH 0/6] Eliminate infrun_thread_thread_exit observer Pedro Alves
2022-12-03 21:13 ` Pedro Alves [this message]
2022-12-08 21:30 ` [PATCH 1/6] Tweak "Using the running image of ..." output Simon Marchi
2022-12-03 21:13 ` [PATCH 2/6] Convert previous_inferior_ptid to strong reference to thread_info Pedro Alves
2022-12-03 21:13 ` [PATCH 3/6] Improve "info program" Pedro Alves
2022-12-03 21:13 ` [PATCH 4/6] Make follow_fork not rely on get_last_target_status Pedro Alves
2022-12-03 21:13 ` [PATCH 5/6] all-stop "follow-fork parent" and selecting another thread Pedro Alves
2022-12-03 21:13 ` [PATCH 6/6] Remove infrun_thread_thread_exit observer Pedro Alves
2023-02-27 19:12 ` [PATCH 0/6] Eliminate " Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221203211338.2264994-2-pedro@palves.net \
--to=pedro@palves.net \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).