From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) by sourceware.org (Postfix) with ESMTPS id 412E13864A30 for ; Mon, 12 Dec 2022 20:31:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 412E13864A30 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f42.google.com with SMTP id ay14-20020a05600c1e0e00b003cf6ab34b61so6251903wmb.2 for ; Mon, 12 Dec 2022 12:31:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=meppP8j9rt8VqyyHra6pudD85BcyEFHJypKvkZQco0o=; b=wjWCq+8E6+Roi/ieJ53zAvyKR7RewH45/WwHQR13ENgQoRgg4AysqsJ8kxP8tZM/h6 E0chnpRH4MZhXwknr8ScTPWQoNCtgue9WgBxbqDk8kRAH/akx54OPm99Uq14cccUHUYH AnFoOuEYj6qCRohE1vTt38N6gKtxto70SNlbEJ3aoNwFTyVIdxSXBs3Dv+L2i9mrGuzx xyLVNQmxgwOSDnJyMfjhcW6qGrACsUSAoVXjuPP9qZgu/K1CWGndsid8DVSBSzLk+fm4 5lK6S8S7swIqsPgtID5BeKjjS7yayq0zQen9MGEjsx0feheBhp4fTS6nAPwpYGzvmNub whXw== X-Gm-Message-State: ANoB5plACG/wb9oy98PBClB+Kb3jHyNahuUezlFImrMweIOSX+V9EAJg Wp69Pzx9PR2D/4CEVQvXAY7jOry9P6sAJg== X-Google-Smtp-Source: AA0mqf7T6+HloackxXk8pNxtdcYBh3kO3l1FZyoQcRpnmEaUmvCQoD2IJBgDURzKAI0qXaUCuhZk7w== X-Received: by 2002:a05:600c:1da3:b0:3d1:ebdf:d58b with SMTP id p35-20020a05600c1da300b003d1ebdfd58bmr14311214wms.5.1670877079147; Mon, 12 Dec 2022 12:31:19 -0800 (PST) Received: from localhost ([2001:8a0:f912:6700:afd9:8b6d:223f:6170]) by smtp.gmail.com with ESMTPSA id e17-20020a5d5951000000b0024278304ef6sm9697946wri.13.2022.12.12.12.31.18 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Dec 2022 12:31:18 -0800 (PST) From: Pedro Alves To: gdb-patches@sourceware.org Subject: [PATCH 15/31] gdbserver/linux-low.cc: Ignore event_ptid if TARGET_WAITKIND_IGNORE Date: Mon, 12 Dec 2022 20:30:45 +0000 Message-Id: <20221212203101.1034916-16-pedro@palves.net> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20221212203101.1034916-1-pedro@palves.net> References: <20221212203101.1034916-1-pedro@palves.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-10.4 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,GIT_PATCH_0,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: gdbserver's linux_process_target::wait loops if called sync mode, and wait_1 returns TARGET_WAITKIND_IGNORE, _and_ wait_1 also returns null_ptid. The null_ptid check fails however when this path is taken: ptid_t linux_process_target::filter_exit_event (lwp_info *event_child, target_waitstatus *ourstatus) { ... if (!is_leader (thread)) { if (report_exit_events_for (thread)) ourstatus->set_thread_exited (0); else ourstatus->set_ignore (); <<<<<<< delete_lwp (event_child); } return ptid; } This makes linux_process_target::wait return TARGET_WAITKIND_IGNORE in sync mode, which is unexpected by the core and fails an assertion. This commit fixes it by just making linux_process_target::wait loop if it got a TARGET_WAITKIND_IGNORE, irrespective of event_ptid. Change-Id: I39776908a6c75cbd68aa04139ffcf7be334868cf --- gdbserver/linux-low.cc | 1 - 1 file changed, 1 deletion(-) diff --git a/gdbserver/linux-low.cc b/gdbserver/linux-low.cc index a7c310260ca..8c0d3103398 100644 --- a/gdbserver/linux-low.cc +++ b/gdbserver/linux-low.cc @@ -3636,7 +3636,6 @@ linux_process_target::wait (ptid_t ptid, event_ptid = wait_1 (ptid, ourstatus, target_options); } while ((target_options & TARGET_WNOHANG) == 0 - && event_ptid == null_ptid && ourstatus->kind () == TARGET_WAITKIND_IGNORE); /* If at least one stop was reported, there may be more. A single -- 2.36.0