public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Simon Marchi <simon.marchi@polymtl.ca>
To: gdb-patches@sourceware.org
Cc: Simon Marchi <simon.marchi@polymtl.ca>
Subject: [PATCH] gdb/testsuite: don't delete command files in gdb.base/commands.exp
Date: Wed, 14 Dec 2022 16:14:03 -0500	[thread overview]
Message-ID: <20221214211403.635684-1-simon.marchi@polymtl.ca> (raw)

Don't delete the runtime-generated command files.  This makes it easier
to reproduce tests by hand.

Change-Id: I4e53484eea216512f1c5d7dfcb5c464b36950946
---
 gdb/testsuite/gdb.base/commands.exp | 14 ++++----------
 1 file changed, 4 insertions(+), 10 deletions(-)

diff --git a/gdb/testsuite/gdb.base/commands.exp b/gdb/testsuite/gdb.base/commands.exp
index 933978c0ea10..929a48e47dc3 100644
--- a/gdb/testsuite/gdb.base/commands.exp
+++ b/gdb/testsuite/gdb.base/commands.exp
@@ -714,8 +714,6 @@ maintenance deprecate set qqq_aaa"
     gdb_test "set qqq_aaa" \
 	"Warning: 'set qqq_aaa', an alias for the command 'set xxx_yyy', is deprecated\\.\r\n.*No alternative known\\..*" \
 	"deprecated alias with prefix give a warning"
-
-    file delete $file1
 }
 
 # Test that the help for a command does not show deprecated aliases.
@@ -848,7 +846,7 @@ proc_with_prefix stray_arg0_test { } {
 
 # Test that GDB is able to source a file with an indented comment.
 proc_with_prefix source_file_with_indented_comment {} {
-    set file1 [standard_output_file file1]
+    set file1 [standard_output_file source_file_with_indented_comment]
 
     set fd [open "$file1" w]
     puts $fd \
@@ -864,9 +862,9 @@ echo Done!\n}
 # Test that GDB can handle arguments when sourcing files recursively.
 # If the arguments are overwritten with ####### then the test has failed.
 proc_with_prefix recursive_source_test {} {
-    set file1 [standard_output_file file1]
-    set file2 [standard_output_file file2]
-    set file3 [standard_output_file file3]
+    set file1 [standard_output_file recursive_source_1]
+    set file2 [standard_output_file recursive_source_2]
+    set file3 [standard_output_file recursive_source_3]
 
     set fd [open "$file1" w]
     puts $fd \
@@ -892,10 +890,6 @@ end"
     gdb_test "source $file1" \
 	"1: <<<qwerty>>>\[\r\n]+in file3\[\r\n]+2: <<<qwerty>>>" \
 	"source file"
-
-    file delete $file1
-    file delete $file2
-    file delete $file3
 }
 
 proc gdb_test_no_prompt { command result msg } {

base-commit: 5d80df4a109e7b648e324423a5fbc3c1ba02e816
-- 
2.38.1


             reply	other threads:[~2022-12-14 21:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-14 21:14 Simon Marchi [this message]
2022-12-15 19:20 ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221214211403.635684-1-simon.marchi@polymtl.ca \
    --to=simon.marchi@polymtl.ca \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).