From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd35.google.com (mail-io1-xd35.google.com [IPv6:2607:f8b0:4864:20::d35]) by sourceware.org (Postfix) with ESMTPS id ED070389637B for ; Thu, 15 Dec 2022 19:08:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org ED070389637B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-io1-xd35.google.com with SMTP id z144so121143iof.3 for ; Thu, 15 Dec 2022 11:08:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ztD+KOj2nzCcvPOSwjQJi8E0LDZWEdtG6OJADk70nw8=; b=CauB8G/QDrf3/rMA9T/+0I/MRxtzdQhf04u0H9KCC1hSzXNe/aQEmumsW2FioaEOTP P6HZbkkj+Gp7STG39b4JGs1lel7t+6NBtvcJEeXQUoi/uLzms133jwGyzvwyDzsXXTyV bik+rQtUStJDES29T+Wmm3CF99CdzfeuPveBnCBLWoGEcbNvdSNlmUTAbLuzpuGmQW0g rymckuBPDsWA6Pgk34qxbPfFV5NE+j36gZjMKYog6c/JUTtnAlszdRks9C9c19frmEkn H1jX7rB3k+W+jmcvV5OAnVNN0Yn08xkyZ6QrAbip8MzY2RIQQ1GNbFUnJ/oNsAwnr3cg jYlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ztD+KOj2nzCcvPOSwjQJi8E0LDZWEdtG6OJADk70nw8=; b=OQtf9bMCuSfmX6B1kd3F6uVIu+GByjkOSrOfuEqTL4SO+1aOMb4mWVVmcrPt9Q7fXe LkjG6phaV3hdaZufg0efix8G4XtCtZ17DN1FCcFQfhfUaxoCRWBBII76VGRtm3M4NfjD rXvVB3vx0iNAwt2hZNDvlCJTn/N+J102P+eMPnhh6r5o8YONmljQuTywbPjiZcJrW2aO Yuzg6NpDbtbIgjWWQ4nuCuaPIgjg9N5uMKadQOHnSn0AEJZSMCuoEGvbphs3QA4r0zoD qjtiwhhVydIlsbCakOoCBsDNs36aG8fvXWjVG5B8b0IT6P9hg2dt9/6wk8v29Q4rB0w0 GDaw== X-Gm-Message-State: ANoB5pns6UlzG4jX8Uc23FVyhDdwXyeU46h06Go8OgBHW55kghdKQLyl nmPaig+RIM6H4YRurWe5nHCbnKuVXu4SVj7Q X-Google-Smtp-Source: AA0mqf4JjQIqIdRHfrOy3wK8DpvCVQOpHIszbW3eTdt681atYke3Tk2VIwM7MgmV1lrKTOz10bVu+g== X-Received: by 2002:a6b:d00d:0:b0:6e5:ef2:8451 with SMTP id x13-20020a6bd00d000000b006e50ef28451mr1167777ioa.20.1671131291123; Thu, 15 Dec 2022 11:08:11 -0800 (PST) Received: from localhost.localdomain (97-122-76-186.hlrn.qwest.net. [97.122.76.186]) by smtp.gmail.com with ESMTPSA id y74-20020a6bc84d000000b006e0338b60a5sm1413962iof.22.2022.12.15.11.08.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Dec 2022 11:08:10 -0800 (PST) From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH 2/4] Don't erase empty indices in DWARF reader Date: Thu, 15 Dec 2022 12:07:57 -0700 Message-Id: <20221215190759.2494095-3-tromey@adacore.com> X-Mailer: git-send-email 2.34.3 In-Reply-To: <20221215190759.2494095-1-tromey@adacore.com> References: <20221215190759.2494095-1-tromey@adacore.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: The DWARF reader has some code to remove empty indices. However, I think this code has been obsolete since some earlier changes to parallel_for_each. This patch removes this code. --- gdb/dwarf2/read.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c index 032e20af93a..a3f4ef351eb 100644 --- a/gdb/dwarf2/read.c +++ b/gdb/dwarf2/read.c @@ -7170,16 +7170,6 @@ dwarf2_build_psymtabs_hard (dwarf2_per_objfile *per_objfile) print_tu_stats (per_objfile); indexes.push_back (index_storage.release ()); - /* Remove any NULL entries. This might happen if parallel-for - decides to throttle the number of threads that were used. */ - indexes.erase - (std::remove_if (indexes.begin (), - indexes.end (), - [] (const std::unique_ptr &entry) - { - return entry == nullptr; - }), - indexes.end ()); indexes.shrink_to_fit (); cooked_index_vector *vec = new cooked_index_vector (std::move (indexes)); -- 2.34.3