From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 602EB3858D1E for ; Thu, 22 Dec 2022 15:13:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 602EB3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 2BMFDotA026993 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 22 Dec 2022 10:13:55 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 2BMFDotA026993 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1671722035; bh=9NtbUMvCZBcX43v4QSFpvRkPOwQkJxbCSGGosBDcSe8=; h=From:To:Cc:Subject:Date:From; b=GO3EAI7vZPxeeSX1Nt0A/4sPN6FnJ6Q21EznxfiYjbvGQVMGQA92+ZEiGcCHrpACg rWz+xZsXK5l9+Kl71lLFN/vHVULLI26PTyqcTq64cjFyIDo/yF5VQ+UfPCfl6uyCSC om9zif+ochnN/LR4rBRqUnaHo+h17Hl58syaHHpg= Received: from simark.localdomain (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 4FC5C1E112; Thu, 22 Dec 2022 10:13:50 -0500 (EST) From: Simon Marchi To: gdb-patches@sourceware.org Cc: Andrew Pinski , Simon Marchi Subject: [PATCH] gdb/testsuite: remove MPFR detection in gdb.base/float128.exp Date: Thu, 22 Dec 2022 10:13:49 -0500 Message-Id: <20221222151349.2320082-1-simon.marchi@polymtl.ca> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 22 Dec 2022 15:13:50 +0000 X-Spam-Status: No, score=-3189.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: I see this fail since commit 991180627851 ("Use toplevel configure for GMP and MPFR for gdb"): FAIL: gdb.base/float128.exp: show configuration The test fails to find --with-mpfr or --without-mpfr in the "show configuration" output. Since MPFR has become mandatory, we can just remove that check and simplify the test to assume MPFR support is there. Change-Id: I4f3458470db0029705b390dfefed3a66dfc0633a --- gdb/testsuite/gdb.base/float128.exp | 37 +---------------------------- 1 file changed, 1 insertion(+), 36 deletions(-) diff --git a/gdb/testsuite/gdb.base/float128.exp b/gdb/testsuite/gdb.base/float128.exp index 21a1a99f6ee7..73835942ab0c 100644 --- a/gdb/testsuite/gdb.base/float128.exp +++ b/gdb/testsuite/gdb.base/float128.exp @@ -73,40 +73,5 @@ gdb_test_multiple "set var f128=20.375l" "$test" { gdb_test "print ld" ".* = 10\\.375.*" "the value of ld is changed to 10.375" gdb_test "print f128" ".* = 20\\.375.*" "the value of f128 is changed to 20.375" -set mpfr_supported -1 -gdb_test_multiple "show configuration" "" { - -wrap -re "--with-mpfr\r\n.*" { - set mpfr_supported 1 - } - -wrap -re "--without-mpfr\r\n.*" { - set mpfr_supported 0 - } -} - # Test that we can correctly handle the largest IEEE-128 value -# Note: If we get "inf" instead of the correct result, we may have run into -# an internal overflow. This typically happens on host platforms without -# native IEEE-128 support where GDB was built without MPFR support. -set test "print large128" -gdb_test_multiple "print large128" "$test" { - -re ".* = 1\\.18973149535723176508575932662800702e\\+4932.*$gdb_prompt $" { - pass "$test" - } - -re ".* = inf.*$gdb_prompt $" { - if { $mpfr_supported == 0 } { - # If the host platform has native 128-bit float support (as is - # the case for some versions of s390 and powerpc), the - # "print large128" test should be passing, even without MPFR - # support. So, in those cases we should have fail here rather than - # unsupported. However, given that we don't have a way to readily - # test for this, we fall back to unsupported. - unsupported "$test (Missing MPFR support)" - } else { - fail $test - } - } - -re ".*$gdb_prompt $" { - fail "$test" - } -} - +gdb_test "print large128" ".* = 1\\.18973149535723176508575932662800702e\\+4932" base-commit: a5ce326cfeb364a33d8ee9c806780347a92b5d18 -- 2.38.1