From: Lancelot SIX <lsix@lancelotsix.com>
To: Tom Tromey <tromey@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 0/2] Two minor expression changes
Date: Tue, 3 Jan 2023 22:50:29 +0000 [thread overview]
Message-ID: <20230103225029.lxmfxidleagonxbr@ubuntu.lan> (raw)
In-Reply-To: <20221219181732.469376-1-tromey@adacore.com>
Hi,
I went through both patches and for what it is worth, they look good to
me.
Feel free to add
Reviewed-By: Lancelot Six <lancelot.six@amd.com>
Best,
Lancelot.
On Mon, Dec 19, 2022 at 11:17:30AM -0700, Tom Tromey via Gdb-patches wrote:
> I found a couple of spots where the expression code could be slightly
> modernized.
>
> Tom
>
>
next prev parent reply other threads:[~2023-01-03 22:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-19 18:17 Tom Tromey
2022-12-19 18:17 ` [PATCH 1/2] Convert exp_uses_objfile to a method of expression Tom Tromey
2022-12-19 18:17 ` [PATCH 2/2] Use first_opcode in another spot Tom Tromey
2023-01-03 22:50 ` Lancelot SIX [this message]
2023-01-04 16:47 ` [PATCH 0/2] Two minor expression changes Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230103225029.lxmfxidleagonxbr@ubuntu.lan \
--to=lsix@lancelotsix.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).